From: Oleg Nesterov <oleg@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@linux.com>, Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3
Date: Wed, 5 Aug 2015 19:10:57 +0200 [thread overview]
Message-ID: <20150805171057.GA20238@redhat.com> (raw)
In-Reply-To: <1438014440-20669-1-git-send-email-fweisbec@gmail.com>
On 07/27, Frederic Weisbecker wrote:
>
> Hence those two debatable changes:
>
> _ We would like to use generic workqueues. System unbound workqueues are
> a very good candidate but they are not wide affine, only node affine.
> Now probably a node is enough to perform many parallel kmod jobs.
>
> _ We would like to remove the wait_for_helper kernel thread (UMH_WAIT_PROC
> handler) to use the workqueue. It means that if the workqueue blocks,
> and no other worker can take pending kmod request, we can be screwed.
> Now if we have 512 threads, this should be enough.
I think this series is fine. Feel free to add my reviewed-by.
Oleg.
next prev parent reply other threads:[~2015-08-05 17:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 16:27 [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3 Frederic Weisbecker
2015-07-27 16:27 ` [PATCH 1/5] kmod: Bunch of internal functions renames Frederic Weisbecker
2015-07-27 16:27 ` [PATCH 2/5] kmod: Remove unecessary explicit wide CPU affinity setting Frederic Weisbecker
2015-07-27 16:27 ` [PATCH 3/5] kmod: Add up-to-date explanations on the purpose of each asynchronous levels Frederic Weisbecker
2015-07-27 16:27 ` [PATCH 4/5] kmod: Use system_unbound_wq instead of khelper Frederic Weisbecker
2015-07-27 16:27 ` [PATCH 5/5] kmod: Handle UMH_WAIT_PROC from system unbound workqueue Frederic Weisbecker
2015-07-27 18:48 ` [PATCH 0/5] kmod: Cleanups, simplifications, and make isolation friendly v3 Tejun Heo
2015-07-27 21:05 ` Frederic Weisbecker
2015-07-28 18:01 ` Tejun Heo
2015-07-28 18:07 ` Frederic Weisbecker
2015-08-05 17:10 ` Oleg Nesterov [this message]
2015-08-05 22:14 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805171057.GA20238@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox