From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: peterhuewe@gmx.de, tpmdd-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, NeilBrown <neilb@suse.de>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v8 1/3] sysfs: added sysfs_link_entry_to_kobj()
Date: Wed, 5 Aug 2015 13:11:23 -0700 [thread overview]
Message-ID: <20150805201123.GB15839@kroah.com> (raw)
In-Reply-To: <1435933643-4516-2-git-send-email-jarkko.sakkinen@linux.intel.com>
On Fri, Jul 03, 2015 at 05:27:18PM +0300, Jarkko Sakkinen wrote:
> Added a new function sysfs_link_group_to_kobj() that adds a symlink
> from attribute or group to a kobject. Exported kernfs_remove_by_name_ns
> in order to provide a way to remove such symlinks.
This text doesn't match the function name you exported :(
>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> ---
> fs/sysfs/group.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> include/linux/sysfs.h | 10 ++++++++++
> 2 files changed, 54 insertions(+)
>
> diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c
> index b400c04..0fb4b6e 100644
> --- a/fs/sysfs/group.c
> +++ b/fs/sysfs/group.c
> @@ -352,3 +352,47 @@ void sysfs_remove_link_from_group(struct kobject *kobj, const char *group_name,
> }
> }
> EXPORT_SYMBOL_GPL(sysfs_remove_link_from_group);
> +
> +/**
> + * __compat_sysfs_link_entry_to_kobj - add a symlink to a kobject pointing
Why __compat?
next prev parent reply other threads:[~2015-08-05 20:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 14:27 [PATCH v8 0/3] Enable PPI sysfs interface for TPM 2.0 Jarkko Sakkinen
2015-07-03 14:27 ` [PATCH v8 1/3] sysfs: added sysfs_link_entry_to_kobj() Jarkko Sakkinen
2015-08-05 20:11 ` Greg Kroah-Hartman [this message]
2015-08-10 8:40 ` Jarkko Sakkinen
2015-07-03 14:27 ` [PATCH v8 2/3] tpm: move the PPI attributes to character device directory Jarkko Sakkinen
2015-07-03 14:27 ` [PATCH v8 3/3] tpm: update PPI documentation to address the location change Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805201123.GB15839@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=neilb@suse.de \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox