From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932120AbbHEUPD (ORCPT ); Wed, 5 Aug 2015 16:15:03 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37214 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753293AbbHEUPA (ORCPT ); Wed, 5 Aug 2015 16:15:00 -0400 Date: Wed, 5 Aug 2015 13:14:59 -0700 From: Greg KH To: "Philip P. Moltmann" Cc: dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, xdeguillard@vmware.com, akpm@linux-foundation.org, pv-drivers@vmware.com Subject: Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node. Message-ID: <20150805201459.GA16009@kroah.com> References: <20150612161513.GA23859@dtor-pixel> <1434134610-2831-6-git-send-email-moltmann@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434134610-2831-6-git-send-email-moltmann@vmware.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 12, 2015 at 11:43:26AM -0700, Philip P. Moltmann wrote: > This helps with debugging vmw_balloon behavior, as it is clear what > functionality is enabled. > > Acked-by: Andy King > Signed-off-by: Xavier Deguillard > --- > drivers/misc/vmw_balloon.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c > index 72247d9..6eaf7f7 100644 > --- a/drivers/misc/vmw_balloon.c > +++ b/drivers/misc/vmw_balloon.c > @@ -46,7 +46,7 @@ > > MODULE_AUTHOR("VMware, Inc."); > MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver"); > -MODULE_VERSION("1.3.2.0-k"); > +MODULE_VERSION("1.3.3.0-k"); This constant change of module version is annoying, is it really even needed? I'll take this, but seriously consider just dropping it entirely as it doesn't mean anything now that the driver is in the kernel tree. thanks, greg k-h