From: Darren Hart <dvhart@infradead.org>
To: "Łukasz Stelmach" <stlman@poczta.fm>
Cc: Corentin Chary <corentin.chary@gmail.com>,
acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] asus-laptop: Add key found on Asus F3M
Date: Wed, 5 Aug 2015 13:29:07 -0700 [thread overview]
Message-ID: <20150805202907.GD12131@vmdeb7> (raw)
In-Reply-To: <1438198283-2180-1-git-send-email-stlman@poczta.fm>
On Wed, Jul 29, 2015 at 09:31:23PM +0200, Łukasz Stelmach wrote:
> Asus F3M has two keys labeled with an icon of a touchpad. The first,
> reported as 0x6B is next to the power key and the second, reported as
> 0x6A, is F9 combined with Fn button. When I was pressing the latter, I was
> getting "Unknown key 6a pressed" message before applying this patch.
>
> Asus F3M does not support WMI so the commit does not update key mappings
> in the asus-nb-wmi.c file.
>
> I have not tested this mapping on any other Asus laptop.
>
> Signed-off-by: Łukasz Stelmach <stlman@poczta.fm>
Thanks Łukasz.
Corentin, any concerns?
> ---
> drivers/platform/x86/asus-laptop.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index 58d29c4..f2b5d0a 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -332,6 +332,7 @@ static const struct key_entry asus_keymap[] = {
> {KE_KEY, 0x65, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + TV */
> {KE_KEY, 0x66, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + TV */
> {KE_KEY, 0x67, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV */
> + {KE_KEY, 0x6A, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad Fn + F9 */
> {KE_KEY, 0x6B, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad */
> {KE_KEY, 0x6C, { KEY_SLEEP } }, /* Suspend */
> {KE_KEY, 0x6D, { KEY_SLEEP } }, /* Hibernate */
> --
> 2.1.4
>
>
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-08-05 20:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 17:17 [PATCH] asus-laptop: Add key found on Asus F3M Łukasz Stelmach
2015-07-29 4:43 ` Darren Hart
2015-07-29 19:31 ` [PATCH v2] " Łukasz Stelmach
2015-08-05 20:29 ` Darren Hart [this message]
2015-08-12 7:06 ` Corentin Chary
2015-08-18 5:48 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805202907.GD12131@vmdeb7 \
--to=dvhart@infradead.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stlman@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox