From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753772AbbHEUd1 (ORCPT ); Wed, 5 Aug 2015 16:33:27 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:34391 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752637AbbHEUd0 (ORCPT ); Wed, 5 Aug 2015 16:33:26 -0400 Date: Wed, 5 Aug 2015 13:33:22 -0700 From: "dmitry.torokhov@gmail.com" To: Philip Moltmann Cc: "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "pv-drivers@vmware.com" , Xavier Deguillard , John Savanyo , "akpm@linux-foundation.org" Subject: Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node. Message-ID: <20150805203322.GA39610@dtor-ws> References: <20150612161513.GA23859@dtor-pixel> <1434134610-2831-6-git-send-email-moltmann@vmware.com> <20150805201459.GA16009@kroah.com> <1438806166.31263.203.camel@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438806166.31263.203.camel@vmware.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2015 at 08:22:35PM +0000, Philip Moltmann wrote: > Hi, > > > > MODULE_AUTHOR("VMware, Inc."); > > > MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver"); > > > -MODULE_VERSION("1.3.2.0-k"); > > > +MODULE_VERSION("1.3.3.0-k"); > > > > This constant change of module version is annoying, is it really even > > needed? > > > > I'll take this, but seriously consider just dropping it entirely as > > it > > doesn't mean anything now that the driver is in the kernel tree. > > I think this is meant so that we can track which patches got backported > into RHEL and SLES. That assumes that RHEL and SLES always take everything that is in mainline, which I would not count. I.e if you have a security fix and also change version to 1.3.4.0-k and RedHat picks it up is the driver that they have really 1.3.4.0-k? If not then what? You really need to keep track of the substance of the changes needing to go into each distribution. Thanks. -- Dmitry