From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932095AbbHEWf1 (ORCPT ); Wed, 5 Aug 2015 18:35:27 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:18727 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752265AbbHEWfZ (ORCPT ); Wed, 5 Aug 2015 18:35:25 -0400 Date: Thu, 6 Aug 2015 01:34:55 +0300 From: Dan Carpenter To: Peng Fan Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: fix sparse warning for lock Message-ID: <20150805223455.GD5180@mwanda> References: <1438781204-13283-1-git-send-email-van.freenix@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438781204-13283-1-git-send-email-van.freenix@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2015 at 09:26:44PM +0800, Peng Fan wrote: > Use __acquire() and __release() in the right place to silence the sparse > lock checking warning. > > drivers/staging/sm750fb/sm750.c:177:13: warning: context imbalance in 'lynxfb_ops_fillrect' - different lock contexts for basic block > drivers/staging/sm750fb/sm750.c:243:9: warning: context imbalance in 'lynxfb_ops_copyarea' - different lock contexts for basic block > drivers/staging/sm750fb/sm750.c:247:13: warning: context imbalance in 'lynxfb_ops_imageblit' - different lock contexts for basic block > Sparse is really bad at locking stuff. Smatch is also really bad for locking and I have been promising to re-write that check for years, but I take comfort always in the fact that at least it's not as bad as Sparse. You should pretty much ignore Sparse locking warnings. regards, dan carpenter