Re: [PATCH 6/9] VMware balloon: Do not limit the amount of frees and allocations in non-sleep mode.

Philip Moltmann
2015-06-11T20:10:24Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1400 bytes --]

Hi,

sorry for taking so long to address your concerns.

> What happens if you run this new driver on an older hypervisor that
> does not support batched operations?

When the driver starts or when it gets reset the driver checks for the
capabilities of the hypervisor in vmballoon_send_start. Then it resets
it state and only uses the available functionality.

A reset happens any time the VM get hot migrated, snapshotted, resumed,
etc.

I tested this driver on various versions of ESXi to have a full set of
possible capabilities.

> > - if (allocations >= rate) {
> > + if (rate != -1 && allocations >= rate) {
> > /* We allocated enough pages, let's take a
> > break. */
>
> Why don't you make the rate UINT_MAX when doing fast allocations,
> then
> you would not need to treat -1 as a special case.

Good suggestion.

> > /* free pages to reach target */
> > list_for_each_entry_safe(page, next, &b->pages, lru) {
> > list_del(&page->lru);
> > b->ops->add_page(b, num_pages++, page);
> >
> > +
>
> Seems line unintended whitespace addition.

I could not find this in the code.

I will send out a new patch series addressing your concerns.

Thanks
Philipÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥