Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node.

John Savanyo
2015-08-05T20:42:28Z

I agree that version number tracking is not perfect. But it is valuable
for us to use as a rough indication that we have attempted to back port
some appropriate subset of patches from mainline to a sustaining distro
release without having to diff the code.

-John

On 8/5/15, 1:33 PM, "dmitry.torokhov@gmail.com"
<dmitry.torokhov@gmail.com> wrote:

>On Wed, Aug 05, 2015 at 08:22:35PM +0000, Philip Moltmann wrote:
>> Hi,
>>
>> > > MODULE_AUTHOR("VMware, Inc.");
>> > > MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
>> > > -MODULE_VERSION("1.3.2.0-k");
>> > > +MODULE_VERSION("1.3.3.0-k");
>> >
>> > This constant change of module version is annoying, is it really even
>> > needed?
>> >
>> > I'll take this, but seriously consider just dropping it entirely as
>> > it
>> > doesn't mean anything now that the driver is in the kernel tree.
>>
>> I think this is meant so that we can track which patches got backported
>> into RHEL and SLES.
>
>That assumes that RHEL and SLES always take everything that is in
>mainline, which I would not count. I.e if you have a security fix and
>also change version to 1.3.4.0-k and RedHat picks it up is the driver
>that they have really 1.3.4.0-k? If not then what?
>
>You really need to keep track of the substance of the changes needing to
>go into each distribution.
>
>Thanks.
>
>--
>Dmitry