Re: [PATCH 6/9] VMware balloon: Do not limit the amount of frees and allocations in non-sleep mode.

dmitry.torokhov
2015-06-12T11:20:33Z

Hi Philip,

On Thu, Jun 11, 2015 at 08:10:07PM +0000, Philip Moltmann wrote:
> Hi,
>
> sorry for taking so long to address your concerns.
>
> > What happens if you run this new driver on an older hypervisor that
> > does not support batched operations?
>
> When the driver starts or when it gets reset the driver checks for the
> capabilities of the hypervisor in vmballoon_send_start. Then it resets
> it state and only uses the available functionality.
>
> A reset happens any time the VM get hot migrated, snapshotted, resumed,
> etc.
>
> I tested this driver on various versions of ESXi to have a full set of
> possible capabilities.

I understand that you negotiate the capabilities between hypervisor and
the balloon driver, however that was not my concern (and I am sorry that
I did not express it properly).

The patch description stated:

"Before this patch the slow memory transfer would cause the destination
VM to have internal swapping until all memory is transferred. Now the
memory is transferred fast enough so that the destination VM does not
swap."

As far as I understand the improvements in memory transfer speed hinge
on the availability of batched operations, you however remove the limits
on non-sleep allocations unconditionally. Thus my question: on older
ESXi's that do not support batcher operations won't this cause VM to
start swapping?

Thanks.

--
Dmitry