From: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
To: Jonathan Corbet <corbet@lwn.net>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vivek Goyal <vgoyal@redhat.com>
Cc: linux-doc@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@kernel.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: [V3 PATCH 0/4] Fix race issues among panic, NMI and crash_kexec
Date: Thu, 06 Aug 2015 14:45:43 +0900 [thread overview]
Message-ID: <20150806054543.25766.29590.stgit@softrs> (raw)
When an HA cluster software or administrator detects non-response
of a host, they issue an NMI to the host to completely stop current
works and take a crash dump. If the kernel has already panicked
or is capturing a crash dump at that time, further NMI can cause
a crash dump failure.
Also, crash_kexec() called from oops context and panic() can
cause race conditions.
To solve these issue, this patch set does following things:
- Don't panic on NMI if the kernel has already panicked
- Extend exclusion control currently done by panic_lock to crash_kexec
- Introduce "noextnmi" boot option which masks external NMI at the
boot time (supported only for x86)
V3:
- Introduce nmi_panic() macro to reduce code duplication
- In the case of panic on NMI, don't return from NMI handlers
if another cpu already panicked
V2:
- Use atomic_cmpxchg() instead of current spin_trylock() to exclude
concurrent accesses to panic() and crash_kexec()
- Don't introduce no-lock version of panic() and crash_kexec()
---
Hidehiro Kawai (4):
panic/x86: Fix re-entrance problem due to panic on NMI
panic/x86: Allow cpus to save registers even if they are looping in NMI context
kexec: Fix race between panic() and crash_kexec() called directly
x86/apic: Introduce noextnmi boot option
Documentation/kernel-parameters.txt | 4 ++++
arch/x86/kernel/apic/apic.c | 17 ++++++++++++++++-
arch/x86/kernel/nmi.c | 15 +++++++++++----
arch/x86/kernel/reboot.c | 11 +++++++++++
include/linux/kernel.h | 21 +++++++++++++++++++++
kernel/kexec.c | 20 ++++++++++++++++++++
kernel/panic.c | 23 ++++++++++++++++++++---
kernel/watchdog.c | 5 +++--
8 files changed, 106 insertions(+), 10 deletions(-)
--
Hidehiro Kawai
Hitachi, Ltd. Research & Development Group
next reply other threads:[~2015-08-06 5:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 5:45 Hidehiro Kawai [this message]
2015-08-06 5:45 ` [V3 PATCH 1/4] panic/x86: Fix re-entrance problem due to panic on NMI Hidehiro Kawai
2015-08-20 23:45 ` Peter Zijlstra
2015-08-22 0:46 ` 河合英宏 / KAWAI,HIDEHIRO
2015-08-06 5:45 ` [V3 PATCH 2/4] panic/x86: Allow cpus to save registers even if they are looping in NMI context Hidehiro Kawai
2015-08-20 23:18 ` Peter Zijlstra
2015-08-22 1:43 ` 河合英宏 / KAWAI,HIDEHIRO
2015-08-06 5:45 ` [V3 PATCH 3/4] kexec: Fix race between panic() and crash_kexec() called directly Hidehiro Kawai
2015-08-20 23:08 ` Peter Zijlstra
2015-08-22 2:35 ` 河合英宏 / KAWAI,HIDEHIRO
2015-08-25 14:52 ` Peter Zijlstra
2015-08-26 3:11 ` 河合英宏 / KAWAI,HIDEHIRO
2015-08-31 8:53 ` 河合英宏 / KAWAI,HIDEHIRO
2015-08-31 9:07 ` Peter Zijlstra
2015-08-31 9:57 ` 河合英宏 / KAWAI,HIDEHIRO
2015-08-06 5:45 ` [V3 PATCH 4/4] x86/apic: Introduce noextnmi boot option Hidehiro Kawai
2015-08-07 14:38 ` [V3 PATCH 0/4] Fix race issues among panic, NMI and crash_kexec Michal Hocko
2015-08-20 23:17 ` Peter Zijlstra
2015-08-22 0:41 ` 河合英宏 / KAWAI,HIDEHIRO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150806054543.25766.29590.stgit@softrs \
--to=hidehiro.kawai.ez@hitachi.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox