From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755347AbbHFKby (ORCPT ); Thu, 6 Aug 2015 06:31:54 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:14383 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754739AbbHFKbw convert rfc822-to-8bit (ORCPT ); Thu, 6 Aug 2015 06:31:52 -0400 Date: Thu, 6 Aug 2015 11:31:49 +0100 From: Liviu Dudau To: David Miller Cc: "mlindner@marvell.com" , "stephen@networkplumber.org" , "ryan.harkin@linaro.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] sky2: Add module parameter for passing the MAC address Message-ID: <20150806103149.GJ20890@e106497-lin.cambridge.arm.com> References: <1438789854-29194-1-git-send-email-Liviu.Dudau@arm.com> <20150805.173233.539752020022715092.davem@davemloft.net> MIME-Version: 1.0 In-Reply-To: <20150805.173233.539752020022715092.davem@davemloft.net> User-Agent: Mutt/1.5.22 (2013-10-16) X-OriginalArrivalTime: 06 Aug 2015 10:31:49.0247 (UTC) FILETIME=[1A0948F0:01D0D033] X-MC-Unique: xLZ8nqFxQbWFsOLp_T-6Ng-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 06, 2015 at 01:32:33AM +0100, David Miller wrote: > From: Liviu Dudau > Date: Wed, 5 Aug 2015 16:50:54 +0100 > > > For designs where EEPROMs are not connected to PCI Yukon2 > > chips we need to get the MAC address from the firmware. > > Add a module parameter called 'mac_address' for this. It > > will be used if no DT node can be found and the B2_MAC > > register holds an invalid value. > > > > Signed-off-by: Liviu Dudau > > Sorry, such module options are absolutely not allowed. Please clarify if this is a drivers/net/ethernet policy or that is true for the larger subsystem. There are a few networking drivers that have a mac_addr module parameter. I personally used drivers/net/ethernet/8390/pcnet_cs.c as inspiration for my patch. > > If an invalid MAC is present, it should be set to a random > one via eth_random_addr(). > Understood. Stephen Hemminger has provided a patch that I can try and I will report back with the results. Best regards, Liviu -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯