make htmldocs on linux-next failed with warnings.

make htmldocs on linux-next failed with warnings.

[Masanari Iida]

make htmldocs on linux-next have some parser warnings.
Following commit cause the warning.

commit b44158b17099ed5c7c8f4bfb7029942adbfbc318
Author: Ben Hutchings <ben@decadent.org.uk>
Date:   Wed Jul 8 20:07:05 2015 +0100

    DocBook: Avoid building man pages repeatedly and inconsistently

Warning message detail.
/home/iida/Repo/linux-next/Documentation/DocBook/device-drivers.xml:
36171: parser warning : xmlParsePITarget: invalid name prefix 'xml'
 <?xmlif if excludeextra='1'?>
       ^
/home/iida/Repo/linux-next/Documentation/DocBook/device-drivers.xml:
36172: parser warning : xmlParsePITarget: invalid name prefix 'xml'
<?xmlif else?>
       ^
/home/iida/Repo/linux-next/Documentation/DocBook/device-drivers.xml:
36457: parser warning : xmlParsePITarget: invalid name prefix 'xml'
<?xmlif fi?>
       ^
/home/iida/Repo/linux-next/Documentation/DocBook/device-drivers.xml:
36908: parser warning : xmlParsePITarget: invalid name prefix 'xml'
<?xmlif if excludeextra='1'?>
       ^
/home/iida/Repo/linux-next/Documentation/DocBook/device-drivers.xml:
36909: parser warning : xmlParsePITarget: invalid name prefix 'xml'
<?xmlif else?>
       ^
/home/iida/Repo/linux-next/Documentation/DocBook/device-drivers.xml:
45909: parser warning : xmlParsePITarget: invalid name prefix 'xml'
<?xmlif fi?>
       ^
How to reproduce
(1) Clone linux-next repo.
(2) make cleandocs
(3) make htmldocs

This symptom can be reproduced current head (as of July/16th),
as well as between "next-20150713" and "next-20150716".

Masanari Iida

Re: make htmldocs on linux-next failed with warnings.

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1868 bytes --]

On Thu, 2015-07-16 at 23:22 +0900, Masanari Iida wrote:
> make htmldocs on linux-next have some parser warnings.
> Following commit cause the warning.

Yes it has warnings but they should be non-fatal.

Ben.

> commit b44158b17099ed5c7c8f4bfb7029942adbfbc318
> Author: Ben Hutchings <ben@decadent.org.uk>
> Date:   Wed Jul 8 20:07:05 2015 +0100
> 
>     DocBook: Avoid building man pages repeatedly and inconsistently
> 
> Warning message detail.
> /home/iida/Repo/linux-next/Documentation/DocBook/device-drivers.xml:
> 36171: parser warning : xmlParsePITarget: invalid name prefix 'xml'
>  <?xmlif if excludeextra='1'?>
>        ^
> /home/iida/Repo/linux-next/Documentation/DocBook/device-drivers.xml:
> 36172: parser warning : xmlParsePITarget: invalid name prefix 'xml'
> <?xmlif else?>
>        ^
> /home/iida/Repo/linux-next/Documentation/DocBook/device-drivers.xml:
> 36457: parser warning : xmlParsePITarget: invalid name prefix 'xml'
> <?xmlif fi?>
>        ^
> /home/iida/Repo/linux-next/Documentation/DocBook/device-drivers.xml:
> 36908: parser warning : xmlParsePITarget: invalid name prefix 'xml'
> <?xmlif if excludeextra='1'?>
>        ^
> /home/iida/Repo/linux-next/Documentation/DocBook/device-drivers.xml:
> 36909: parser warning : xmlParsePITarget: invalid name prefix 'xml'
> <?xmlif else?>
>        ^
> /home/iida/Repo/linux-next/Documentation/DocBook/device-drivers.xml:
> 45909: parser warning : xmlParsePITarget: invalid name prefix 'xml'
> <?xmlif fi?>
>        ^
> How to reproduce
> (1) Clone linux-next repo.
> (2) make cleandocs
> (3) make htmldocs
> 
> This symptom can be reproduced current head (as of July/16th),
> as well as between "next-20150713" and "next-20150716".
> 
> Masanari Iida
-- 
Ben Hutchings
In a hierarchy, every employee tends to rise to his level of incompetence.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

Re: make htmldocs on linux-next failed with warnings.

[Jonathan Corbet]

On Thu, 16 Jul 2015 15:28:56 +0100
Ben Hutchings <ben@decadent.org.uk> wrote:

> On Thu, 2015-07-16 at 23:22 +0900, Masanari Iida wrote:
> > make htmldocs on linux-next have some parser warnings.
> > Following commit cause the warning.  
> 
> Yes it has warnings but they should be non-fatal.

Even so, we don't really want to be adding warnings to the build.
Hopefully it shouldn't be too hard to fix these...?

Thanks,

jon

Re: make htmldocs on linux-next failed with warnings.

[Jonathan Corbet]

On Thu, 16 Jul 2015 08:31:59 -0600
Jonathan Corbet <corbet@lwn.net> wrote:

> On Thu, 16 Jul 2015 15:28:56 +0100
> Ben Hutchings <ben@decadent.org.uk> wrote:
> 
> > On Thu, 2015-07-16 at 23:22 +0900, Masanari Iida wrote:  
> > > make htmldocs on linux-next have some parser warnings.
> > > Following commit cause the warning.    
> > 
> > Yes it has warnings but they should be non-fatal.  
> 
> Even so, we don't really want to be adding warnings to the build.
> Hopefully it shouldn't be too hard to fix these...?

So I've not heard any further on this.  I think at this point I'm going
to revert the patch in question; adding warnings for everybody is just
not the right thing to do.  The other patches in the series can stay.

Having spent some time pondering on the issue, I've also concluded that
this isn't quite the right solution to the problem.  Better, I think, to
have docproc filter out the duplicates directly, and to direct the output
to a different file type (.fxml, say).  Otherwise the .xml files can have
two different things depending on which type of docs was built first,
leading possibly to other formats being built with missing stuff.

I may hack together a solution along these lines, just because I do think
that the reproducible builds goal is an important one.  But I've got a
*bunch* of other stuff that I have to get done, so I'm not quite sure
when I can get to it.

jon

Re: make htmldocs on linux-next failed with warnings.

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1911 bytes --]

On Thu, 2015-08-06 at 12:43 -0600, Jonathan Corbet wrote:
> On Thu, 16 Jul 2015 08:31:59 -0600
> Jonathan Corbet <corbet@lwn.net> wrote:
> 
> > On Thu, 16 Jul 2015 15:28:56 +0100
> > Ben Hutchings <ben@decadent.org.uk> wrote:
> > 
> > > On Thu, 2015-07-16 at 23:22 +0900, Masanari Iida wrote:  
> > > > make htmldocs on linux-next have some parser warnings.
> > > > Following commit cause the warning.    
> > > 
> > > Yes it has warnings but they should be non-fatal.  
> > 
> > Even so, we don't really want to be adding warnings to the build.
> > Hopefully it shouldn't be too hard to fix these...?
> 
> So I've not heard any further on this.

Sorry about that.  I didn't forget about it but didn't have a good idea
how to fix it.

> I think at this point I'm going
> to revert the patch in question; adding warnings for everybody is just
> not the right thing to do.  The other patches in the series can stay.

OK.

> Having spent some time pondering on the issue, I've also concluded that
> this isn't quite the right solution to the problem.  Better, I think, to
> have docproc filter out the duplicates directly, and to direct the output
> to a different file type (.fxml, say).  Otherwise the .xml files can have
> two different things depending on which type of docs was built first,
> leading possibly to other formats being built with missing stuff.
> 
> I may hack together a solution along these lines, just because I do think
> that the reproducible builds goal is an important one.  But I've got a
> *bunch* of other stuff that I have to get done, so I'm not quite sure
> when I can get to it.

I've now thought of another approach, which is to keep the duplicates
during the build process and de-duplicate when installing.  I've just
sent a patch along those lines.

Ben.

-- 
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]