From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Guenter Roeck <linux@roeck-us.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Feldman <sfeldma@gmail.com>, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next v2 3/7] net: dsa: add support for switchdev FDB objects
Date: Thu, 6 Aug 2015 16:04:32 +0200 [thread overview]
Message-ID: <20150806140432.GC19896@lunn.ch> (raw)
In-Reply-To: <1438839848-505-4-git-send-email-vivien.didelot@savoirfairelinux.com>
Hi Vivien
Thanks for splitting up the big patch. This it is much easier to
review now.
Is this patch git bisectable?
Clearly after this patch, but before all the other patches are in, we
will not be programming the hardware. The call into the driver is
removed here, but the replacement is added later. But is the EOPNOTSUP
enough that the system keeps working, by falling back to software?
The two driver APIs are very similar, the main difference being the
MAC address. Can you do the refactoring first, and then make the API
change. That means we can test each patch individually, and have
proper git bisectability.
Thanks
Andrew
next prev parent reply other threads:[~2015-08-06 14:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 5:44 [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects Vivien Didelot
2015-08-06 5:44 ` [PATCH net-next v2 1/7] net: switchdev: change fdb addr for a byte array Vivien Didelot
2015-08-06 5:44 ` [PATCH net-next v2 2/7] net: switchdev: support static FDB addresses Vivien Didelot
2015-08-06 6:28 ` Scott Feldman
2015-08-06 14:19 ` Vivien Didelot
2015-08-06 16:37 ` Scott Feldman
2015-08-06 5:44 ` [PATCH net-next v2 3/7] net: dsa: add support for switchdev FDB objects Vivien Didelot
2015-08-06 14:04 ` Andrew Lunn [this message]
2015-08-06 14:52 ` Vivien Didelot
2015-08-06 5:44 ` [PATCH net-next v2 4/7] net: dsa: mv88e6xxx: extend fid mask Vivien Didelot
2015-08-06 5:44 ` [PATCH net-next v2 5/7] net: dsa: mv88e6xxx: rename ATU MAC accessors Vivien Didelot
2015-08-06 5:44 ` [PATCH net-next v2 6/7] net: dsa: mv88e6xxx: rework FDB getnext operation Vivien Didelot
2015-08-06 5:44 ` [PATCH net-next v2 7/7] net: dsa: mv88e6xxx: rework FDB add/del operations Vivien Didelot
2015-08-10 5:48 ` [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects David Miller
2015-08-10 13:39 ` Vivien Didelot
2015-08-11 16:25 ` Vivien Didelot
2015-08-11 17:38 ` David Miller
2015-08-11 18:03 ` Florian Fainelli
2015-08-11 18:07 ` David Miller
2015-08-11 18:18 ` Vivien Didelot
2015-08-11 18:52 ` David Miller
2015-08-11 19:00 ` David Miller
2015-08-11 19:05 ` David Miller
2015-08-11 20:10 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150806140432.GC19896@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox