From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754323AbbHFOLg (ORCPT ); Thu, 6 Aug 2015 10:11:36 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:43334 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752720AbbHFOLe (ORCPT ); Thu, 6 Aug 2015 10:11:34 -0400 Date: Thu, 6 Aug 2015 16:04:32 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Guenter Roeck , Florian Fainelli , Scott Feldman , Jiri Pirko Subject: Re: [PATCH net-next v2 3/7] net: dsa: add support for switchdev FDB objects Message-ID: <20150806140432.GC19896@lunn.ch> References: <1438839848-505-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1438839848-505-4-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438839848-505-4-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vivien Thanks for splitting up the big patch. This it is much easier to review now. Is this patch git bisectable? Clearly after this patch, but before all the other patches are in, we will not be programming the hardware. The call into the driver is removed here, but the replacement is added later. But is the EOPNOTSUP enough that the system keeps working, by falling back to software? The two driver APIs are very similar, the main difference being the MAC address. Can you do the refactoring first, and then make the API change. That means we can test each patch individually, and have proper git bisectability. Thanks Andrew