From: Greg KH <gregkh@linuxfoundation.org>
To: Adrian Remonda <adrianremonda@gmail.com>
Cc: devel@driverdev.osuosl.org, christian.gromm@microchip.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv6 1/5] Staging: most: mostcore/core.c. Fix "missing static keyword" warnings
Date: Thu, 6 Aug 2015 10:44:12 -0700 [thread overview]
Message-ID: <20150806174412.GA29341@kroah.com> (raw)
In-Reply-To: <1438882500-12716-2-git-send-email-adrianremonda@gmail.com>
On Thu, Aug 06, 2015 at 07:34:56PM +0200, Adrian Remonda wrote:
> This is a patch to the mostcore/core.c file. It makes
> several local functions and structures static to prevent global
> visibility.
>
> v6: fixed warning "line over 80 characters" as pointed out by
> Sudip Mukherjee
The vX line doesn't belong here, it should be below the --- line so that
it is not added to the commit itself.
Please fix up all of these, and resend, I can't take them as-is.
thanks,
greg k-h
next prev parent reply other threads:[~2015-08-06 17:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 17:34 [PATCHv6 0/5] Staging: most: several warnings fix reported by sparse Adrian Remonda
2015-08-06 17:34 ` [PATCHv6 1/5] Staging: most: mostcore/core.c. Fix "missing static keyword" warnings Adrian Remonda
2015-08-06 17:44 ` Greg KH [this message]
2015-08-06 17:34 ` [PATCHv6 2/5] Staging: most: mostcore/core.c. Fix "Using plain integer as NULL pointer" warnings Adrian Remonda
2015-08-06 17:34 ` [PATCHv6 3/5] Staging: most: hdm-usb/hdm_usb.c. Fix "missing static keyword" warnings Adrian Remonda
2015-08-06 21:57 ` Christian Gromm
2015-08-07 7:40 ` AdrianRemonda
2015-08-07 8:42 ` Sudip Mukherjee
2015-08-07 20:52 ` Christian Gromm
2015-08-06 17:34 ` [PATCHv6 4/5] Staging: most: hdm-dim2/dim2_hal.c. Fix "Using plain integer as NULL pointer" warnings Adrian Remonda
2015-08-06 17:35 ` [PATCHv6 5/5] Staging: most: aim-cdev/cdev.c. Fix "missing static keyword" warnings Adrian Remonda
-- strict thread matches above, loose matches on Subject: below --
2015-08-14 9:42 [PATCHv6 0/5] Staging: most: several warnings fix reported by sparse Adrian Remonda
2015-08-14 9:42 ` [PATCHv6 1/5] Staging: most: mostcore/core.c. Fix "missing static keyword" warnings Adrian Remonda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150806174412.GA29341@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adrianremonda@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox