From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Joe Perches <joe@perches.com>, minchan@kernel.org
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Salah Triki <salah.triki@acm.org>,
ngupta@vflare.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] zram: Replace pr_* with dev_*
Date: Fri, 7 Aug 2015 11:03:56 +0900 [thread overview]
Message-ID: <20150807020356.GC1891@swordfish> (raw)
In-Reply-To: <1438912113.2322.7.camel@perches.com>
On (08/06/15 18:48), Joe Perches wrote:
[..]
> > And I saw some time ago people doing that type of thing. So I'd like
> > to avoid unnecessary pain for zram users even if the messages are not
> > guaranteed to remain stable between kernel releases. Just my opinion.
[..]
> because dmesg is not an ABI.
I absolutely agree, this is debatable and controversial. I saw people
grepping dmesg and they treated error messages just like errno codes or
like additional info to attach to errno. Whether we like or not, but, it
seems, for that cases error message is more or less part of ABI. It's
fine when we change _info message, but touching _warn or _err message
is a bit different thing, *I think*. Let's hear from Minchan.
-ss
next prev parent reply other threads:[~2015-08-07 2:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 22:57 [PATCH 0/3] zram: Replace pr_* with dev_* Salah Triki
2015-08-06 23:03 ` [PATCH 1/3] zram: Replace pr_info with dev_info in max_comp_streams_store Salah Triki
2015-08-06 23:03 ` [PATCH 2/3] zram: Replace pr_info with dev_info in comp_algorithm_store Salah Triki
2015-08-06 23:03 ` [PATCH 3/3] zram: Replace pr_* with dev_* Salah Triki
2015-08-07 0:05 ` [PATCH 0/3] " Sergey Senozhatsky
2015-08-07 1:17 ` Joe Perches
2015-08-07 1:42 ` Sergey Senozhatsky
2015-08-07 1:48 ` Joe Perches
2015-08-07 2:03 ` Sergey Senozhatsky [this message]
2015-08-07 2:16 ` Sergey Senozhatsky
2015-08-07 6:05 ` Minchan Kim
2015-08-07 6:37 ` Sergey Senozhatsky
2015-08-07 6:56 ` Sergey Senozhatsky
2015-08-07 7:12 ` Joe Perches
2015-08-07 7:25 ` Sergey Senozhatsky
2015-08-07 14:58 ` Minchan Kim
2015-08-10 1:25 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150807020356.GC1891@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=salah.triki@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox