Re: [PATCH 0/3] zram: Replace pr_* with dev_*

[Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>]

On (08/07/15 11:03), Sergey Senozhatsky wrote:
> [..]
> > because dmesg is not an ABI.
> 
> I absolutely agree, this is debatable and controversial. I saw people
> grepping dmesg and they treated error messages just like errno codes or
> like additional info to attach to errno. Whether we like or not, but, it
> seems, for that cases error message is more or less part of ABI. It's
> fine when we change _info message, but touching _warn or _err message
> is a bit different thing, *I think*. Let's hear from Minchan.
> 

A side note (not to forget).

If Minchan agress that messages are free come and go, then I'd probably
like to remove this one

         meta->table = vzalloc(num_pages * sizeof(*meta->table));
         if (!meta->table) {
                 pr_err("Error allocating zram address table\n");
			^^^^^^
                 goto out_error;
         }

because __vmalloc_node_range() will warn_alloc_failed() anyway.

	-ss