linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Ming Lin <mlin@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Mike Snitzer <snitzer@redhat.com>,
	lkml <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Kent Overstreet <kent.overstreet@gmail.com>,
	Dongsu Park <dpark@posteo.net>,
	Christoph Hellwig <hch@infradead.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Ming Lei <ming.lei@canonical.com>, Neil Brown <neilb@suse.de>,
	Alasdair Kergon <agk@redhat.com>,
	dm-devel@redhat.com, Lars Ellenberg <drbd-dev@lists.linbit.com>,
	drbd-user@lists.linbit.com, Jiri Kosina <jkosina@suse.cz>,
	Geoff Levand <geoff@infradead.org>, Jim Paris <jim@jtan.com>,
	Philip Kelleher <pjk1939@linux.vnet.ibm.com>,
	Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
	Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Ming Lin <ming.l@ssi.samsung.com>
Subject: Re: [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios
Date: Fri, 7 Aug 2015 09:30:01 +0200	[thread overview]
Message-ID: <20150807073001.GA17485@lst.de> (raw)
In-Reply-To: <1438754604.29731.31.camel@hasee>

I'm for solution 3:

 - keep blk_bio_{discard,write_same}_split, but ensure we never built
   a > 4GB bio in blkdev_issue_{discard,write_same}.

Note that this isn't special casing, we can't build > 4GB bios for
data either, it's just implemented as a side effect right now instead
of checked explicitly.

  reply	other threads:[~2015-08-07  7:30 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06  7:44 [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios Ming Lin
2015-07-06  7:44 ` [PATCH v5 02/11] block: simplify bio_add_page() Ming Lin
2015-07-06  7:44 ` [PATCH v5 03/11] bcache: remove driver private bio splitting code Ming Lin
2015-07-06  7:44 ` [PATCH v5 04/11] btrfs: remove bio splitting and merge_bvec_fn() calls Ming Lin
2015-07-06  7:44 ` [PATCH v5 05/11] block: remove split code in blkdev_issue_discard Ming Lin
2015-07-06  7:44 ` [PATCH v5 06/11] md/raid5: split bio for chunk_aligned_read Ming Lin
2015-07-06  7:44 ` [PATCH v5 07/11] md/raid5: get rid of bio_fits_rdev() Ming Lin
2015-07-06  7:44 ` [PATCH v5 08/11] block: kill merge_bvec_fn() completely Ming Lin
2015-07-06  7:44 ` [PATCH v5 09/11] fs: use helper bio_add_page() instead of open coding on bi_io_vec Ming Lin
2015-07-06  7:44 ` [PATCH v5 10/11] block: remove bio_get_nr_vecs() Ming Lin
2015-07-06 10:58   ` Steven Whitehouse
2015-07-06 17:21     ` Ming Lin
2015-07-07  9:04       ` Steven Whitehouse
2015-07-06  7:44 ` [PATCH v5 11/11] Documentation: update notes in biovecs about arbitrarily sized bios Ming Lin
2015-07-31 19:23 ` [PATCH v5 01/11] block: make generic_make_request handle " Mike Snitzer
2015-07-31 21:19   ` Ming Lin
2015-07-31 21:38     ` Mike Snitzer
2015-07-31 22:02       ` Ming Lin
2015-07-31 22:18         ` Ming Lin
2015-08-01  6:58       ` Ming Lin
2015-08-01 16:33         ` Mike Snitzer
2015-08-03  5:58           ` Ming Lin
2015-08-04 11:36             ` Christoph Hellwig
2015-08-05  6:03               ` Ming Lin
2015-08-07  7:30                 ` Christoph Hellwig [this message]
2015-08-07 23:40                   ` Ming Lin
2015-08-08  0:30                     ` Kent Overstreet
2015-08-08  5:17                       ` Ming Lin
2015-08-08  5:22                         ` Kent Overstreet
2015-08-08 12:35                           ` Christoph Hellwig
2015-08-08  8:52                     ` [dm-devel] " Hannes Reinecke
2015-08-08  9:02                       ` Kent Overstreet
2015-08-13  6:04                         ` Hannes Reinecke
2015-08-07  0:00               ` Kent Overstreet
2015-08-07  7:30                 ` Christoph Hellwig
2015-08-08 16:19           ` [dm-devel] " Martin K. Petersen
2015-08-09  5:59             ` Ming Lin
2015-08-09  6:41               ` Christoph Hellwig
2015-08-09  6:55                 ` Ming Lin
2015-08-09  7:01                   ` Christoph Hellwig
2015-08-09  7:18                     ` Ming Lin
2015-08-10 15:02                       ` Mike Snitzer
2015-08-10 16:14                         ` Ming Lin
2015-08-10 16:18                           ` Ming Lin
2015-08-10 16:40                           ` Martin K. Petersen
2015-08-10 18:13                           ` Mike Snitzer
2015-08-10 22:30                             ` Ming Lin
2015-08-10 16:22                         ` Martin K. Petersen
2015-08-10 18:18                           ` Ming Lin
2015-08-11  2:00                             ` Martin K. Petersen
2015-08-11  2:41                               ` Mike Snitzer
2015-08-11  3:38                                 ` Kent Overstreet
2015-08-11 14:08                                   ` Mike Snitzer
2015-08-11 17:49                                   ` Martin K. Petersen
2015-08-11 18:05                                     ` Martin K. Petersen
2015-08-11 20:56                                       ` Ming Lin
2015-08-12  0:24                                         ` Martin K. Petersen
2015-08-12  4:41                                           ` Ming Lin
2015-08-11 17:36                                 ` Martin K. Petersen
2015-08-11 17:47                                   ` Mike Snitzer
2015-08-11 18:01                                     ` [dm-devel] " Martin K. Petersen
  -- strict thread matches above, loose matches on Subject: below --
2015-07-06  7:11 [PATCH v5 00/11] simplify block layer based on immutable biovecs mlin
2015-07-06  7:11 ` [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios mlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150807073001.GA17485@lst.de \
    --to=hch@lst.de \
    --cc=agk@redhat.com \
    --cc=andreas.dilger@intel.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=dpark@posteo.net \
    --cc=drbd-dev@lists.linbit.com \
    --cc=drbd-user@lists.linbit.com \
    --cc=geoff@infradead.org \
    --cc=hch@infradead.org \
    --cc=jim@jtan.com \
    --cc=jkosina@suse.cz \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=ming.l@ssi.samsung.com \
    --cc=ming.lei@canonical.com \
    --cc=mlin@kernel.org \
    --cc=neilb@suse.de \
    --cc=ngupta@vflare.org \
    --cc=oleg.drokin@intel.com \
    --cc=pjk1939@linux.vnet.ibm.com \
    --cc=snitzer@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).