From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932581AbbHGSFy (ORCPT <rfc822;w@1wt.eu>);
	Fri, 7 Aug 2015 14:05:54 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:37742 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932419AbbHGSFx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 7 Aug 2015 14:05:53 -0400
Date: Fri, 7 Aug 2015 11:05:46 -0700
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Feng Tang <feng.tang@intel.com>
Cc: Michal Nazarewicz <mina86@mina86.com>,
        John Stultz <john.stultz@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: ion: Add a default struct device for cma heap
Message-ID: <20150807180546.GD10282@kroah.com>
References: <1438919413-14440-1-git-send-email-feng.tang@intel.com>
 <20150807045404.GA26925@kroah.com>
 <20150807064601.GA9338@shbuild888>
 <xa1t4mkbupc3.fsf@mina86.com>
 <20150807155004.GA22612@shbuild888>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150807155004.GA22612@shbuild888>
User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 07, 2015 at 11:50:04PM +0800, Feng Tang wrote:
> On Fri, Aug 07, 2015 at 04:48:28PM +0200, Michal Nazarewicz wrote:
> > On Fri, Aug 07 2015, Feng Tang wrote:
> > > As I described above, the dummy struct device is only needed for
> > > dma request, its lifetime is align with the cma_heap itself. 
> > 
> > Again, this is from perspective of someone who is unfamiliar with ION,
> > but perhaps a viable solution is to bypass DMA API and just call
> > cma_alloc directly?
> 
> For ion cma heap, the buffer allocation func ion_cma_allocate() will
> call dma_alloc_coherent(dev, ...). And dma_alloc_coherent() is
> implemented by each architeture(arm/m68k/x86 etc), and many Arch's
> implementation doesn't use cma, but use alloc_pages() like APIs.
> So I'm afraid we can't direcly call cma_alloc directly here.

Ick.  But using a "fake" struct device here, for no real reason,
makes me very nervous that you are going to hit a codepath somewhere
that assumes this is a "real" struct device and tries to do something
with it (dev_printk(), look up what bus it is on, change the name of it,
etc.)  Trying to fake out the subsystem in this manner is a sign that
something is really wrong here.

Please either make this a real device, or fix up the api to not need
this type of thing.

thanks,

greg k-h