From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946666AbbHHC1j (ORCPT ); Fri, 7 Aug 2015 22:27:39 -0400 Received: from one.firstfloor.org ([193.170.194.197]:54854 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946416AbbHHC1i (ORCPT ); Fri, 7 Aug 2015 22:27:38 -0400 Date: Sat, 8 Aug 2015 04:27:35 +0200 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Andi Kleen , jolsa@kernel.org, namhyung@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools, report: Add support for srcfile sort key Message-ID: <20150808022735.GC1747@two.firstfloor.org> References: <1438988064-21834-1-git-send-email-andi@firstfloor.org> <20150807235145.GD3583@kernel.org> <20150808000215.GE3583@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150808000215.GE3583@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 07, 2015 at 09:02:15PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Aug 07, 2015 at 08:51:45PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Aug 07, 2015 at 03:54:24PM -0700, Andi Kleen escreveu: > > > From: Andi Kleen > > > > > > In some cases it's useful to characterize samples by file. This is useful > > > to get a higher level categorization, for example to map cost to > > > subsystems. > > > > > > Add a srcfile sort key to perf report. It builds on top of the existing > > > srcline support. > > > > Applied > > Humm, holding this up a bit, further testing showed some oddities, > fedora21, the width of the column is being limited to the lenght of the > header Yes I've seen that, I just use -w normally. It also happens with --sort srcline. The column sizing code could probably be somewhat smarter and always allow the last column to become as wide as needed. But that's something that should be done separately; I don't think it belongs into this patch. > and there are some DWARF errors, have you noticed those? No I didn't. Some generic issue, likely happening with srcline and perhaps even objdump -S too. Find out with strace what file it is. -Andi