From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754547AbbHIJa3 (ORCPT ); Sun, 9 Aug 2015 05:30:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48386 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754475AbbHIJa2 (ORCPT ); Sun, 9 Aug 2015 05:30:28 -0400 Date: Sun, 9 Aug 2015 11:30:24 +0200 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , LKML , David Ahern , Andi Kleen Subject: Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling with '<' and '>' key Message-ID: <20150809093024.GA17069@krava.brq.redhat.com> References: <1439108462-16391-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439108462-16391-1-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 09, 2015 at 05:21:01PM +0900, Namhyung Kim wrote: > Currently perf TUI report browser doesn't support horizontal scrolling. > So if terminal width is smaller than the actual contents, there's no way > to see them. This patch adds support horizontal movement by '<' and '>' > keys. nice, I wonder we could also have some way to scroll by the column width.. it might be more eye friendly? would need to try first ;-) I also tried it with SKIP_COLS_STEP=1, and it wasn't bad how about having several scroll step options? like: , . - SKIP_COLS_STEP=1 < > - SKIP_COLS_STEP=10 CTRL-< > - SKIP_COLS_STEP=columns width we could also bind some of this to regular arrows with SHIFT or CTRL, bacause it's probably the most convenient binding for this jirka