* [PATCH] Staging: dgnc: Fixed line over 80 characters in dgnc_mgmt.c
@ 2015-08-09 16:01 Bhaktipriya Shridhar
0 siblings, 0 replies; 4+ messages in thread
From: Bhaktipriya Shridhar @ 2015-08-09 16:01 UTC (permalink / raw)
To: gregkh, lidza.louina, markh; +Cc: driverdev-devel, devel, linux-kernel
Fixed coding style issue "warning line over 80 characters"
detected by checkpatch.pl in dgnc_mgmt.c
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c
index b13318a..e8fd3da 100644
--- a/drivers/staging/dgnc/dgnc_mgmt.c
+++ b/drivers/staging/dgnc/dgnc_mgmt.c
@@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
di.info_bdstate = dgnc_Board[brd]->dpastatus;
di.info_ioport = 0;
di.info_physaddr = (ulong) dgnc_Board[brd]->membase;
- di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end;
+ di.info_physsize = (ulong) dgnc_Board[brd]->membase -
+ dgnc_Board[brd]->membase_end;
if (dgnc_Board[brd]->state != BOARD_FAILED)
di.info_nports = dgnc_Board[brd]->nasync;
else
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] Staging: dgnc: Fixed line over 80 characters in dgnc_mgmt.c
@ 2015-08-09 15:51 Bhaktipriya Shridhar
0 siblings, 0 replies; 4+ messages in thread
From: Bhaktipriya Shridhar @ 2015-08-09 15:51 UTC (permalink / raw)
To: gregkh, lidza.louina, markh; +Cc: verdev-devel, devel, linux-kernel
Fixed coding style issue "warning line over 80 characters"
detected by checkpatch.pl in dgnc_mgmt.c
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c
index b13318a..e8fd3da 100644
--- a/drivers/staging/dgnc/dgnc_mgmt.c
+++ b/drivers/staging/dgnc/dgnc_mgmt.c
@@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
di.info_bdstate = dgnc_Board[brd]->dpastatus;
di.info_ioport = 0;
di.info_physaddr = (ulong) dgnc_Board[brd]->membase;
- di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end;
+ di.info_physsize = (ulong) dgnc_Board[brd]->membase -
+ dgnc_Board[brd]->membase_end;
if (dgnc_Board[brd]->state != BOARD_FAILED)
di.info_nports = dgnc_Board[brd]->nasync;
else
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] Staging: dgnc: Fixed line over 80 characters in dgnc_mgmt.c
@ 2015-08-09 12:45 Bhaktipriya Shridhar
2015-08-10 9:41 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Bhaktipriya Shridhar @ 2015-08-09 12:45 UTC (permalink / raw)
To: gregkh, lidza.louina, markh; +Cc: driverdev-devel, devel, linux-kernel
Fixed coding style issue "warning line over 80 characters"
detected by checkpatch.pl in dgnc_mgmt.c
---
drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c
index b13318a..e8fd3da 100644
--- a/drivers/staging/dgnc/dgnc_mgmt.c
+++ b/drivers/staging/dgnc/dgnc_mgmt.c
@@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
di.info_bdstate = dgnc_Board[brd]->dpastatus;
di.info_ioport = 0;
di.info_physaddr = (ulong) dgnc_Board[brd]->membase;
- di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end;
+ di.info_physsize = (ulong) dgnc_Board[brd]->membase -
+ dgnc_Board[brd]->membase_end;
if (dgnc_Board[brd]->state != BOARD_FAILED)
di.info_nports = dgnc_Board[brd]->nasync;
else
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: dgnc: Fixed line over 80 characters in dgnc_mgmt.c
2015-08-09 12:45 Bhaktipriya Shridhar
@ 2015-08-10 9:41 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-08-10 9:41 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: gregkh, lidza.louina, markh, devel, driverdev-devel, linux-kernel
On Sun, Aug 09, 2015 at 06:15:36PM +0530, Bhaktipriya Shridhar wrote:
> Fixed coding style issue "warning line over 80 characters"
> detected by checkpatch.pl in dgnc_mgmt.c
No signed off by.
> ---
> drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c
> index b13318a..e8fd3da 100644
> --- a/drivers/staging/dgnc/dgnc_mgmt.c
> +++ b/drivers/staging/dgnc/dgnc_mgmt.c
> @@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> di.info_bdstate = dgnc_Board[brd]->dpastatus;
> di.info_ioport = 0;
> di.info_physaddr = (ulong) dgnc_Board[brd]->membase;
> - di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end;
> + di.info_physsize = (ulong) dgnc_Board[brd]->membase -
> + dgnc_Board[brd]->membase_end;
Better to align it like:
di.info_physsize = (ulong)dgnc_Board[brd]->membase -
dgnc_Board[brd]->membase_end;
But even better would be to rename brd to brd_idx and introduce a new
"struct dgnc_board *brd" variable and set:
brd = dgnc_Board[brd_idx];
Then replace ever reference to "dgnc_Board[brd]" with just "brd".
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-10 9:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-09 16:01 [PATCH] Staging: dgnc: Fixed line over 80 characters in dgnc_mgmt.c Bhaktipriya Shridhar
-- strict thread matches above, loose matches on Subject: below --
2015-08-09 15:51 Bhaktipriya Shridhar
2015-08-09 12:45 Bhaktipriya Shridhar
2015-08-10 9:41 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox