From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933122AbbHIQDj (ORCPT ); Sun, 9 Aug 2015 12:03:39 -0400 Received: from one.firstfloor.org ([193.170.194.197]:57952 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933030AbbHIQDi (ORCPT ); Sun, 9 Aug 2015 12:03:38 -0400 Date: Sun, 9 Aug 2015 18:03:35 +0200 From: Andi Kleen To: Namhyung Kim Cc: Andi Kleen , Arnaldo Carvalho de Melo , jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools, report: Add support for srcfile sort key Message-ID: <20150809160335.GE1747@two.firstfloor.org> References: <1438988064-21834-1-git-send-email-andi@firstfloor.org> <20150807235145.GD3583@kernel.org> <20150808000215.GE3583@kernel.org> <20150808022735.GC1747@two.firstfloor.org> <20150809033049.GE29295@danjae.kornet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150809033049.GE29295@danjae.kornet> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 09, 2015 at 12:30:49PM +0900, Namhyung Kim wrote: > Hi Andi, > > On Sat, Aug 08, 2015 at 04:27:35AM +0200, Andi Kleen wrote: > > On Fri, Aug 07, 2015 at 09:02:15PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Fri, Aug 07, 2015 at 08:51:45PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > Em Fri, Aug 07, 2015 at 03:54:24PM -0700, Andi Kleen escreveu: > > > > > From: Andi Kleen > > > > > > > > > > In some cases it's useful to characterize samples by file. This is useful > > > > > to get a higher level categorization, for example to map cost to > > > > > subsystems. > > > > > > > > > > Add a srcfile sort key to perf report. It builds on top of the existing > > > > > srcline support. > > > > > > > > Applied > > > > > > Humm, holding this up a bit, further testing showed some oddities, > > > fedora21, the width of the column is being limited to the lenght of the > > > header > > > > Yes I've seen that, I just use -w normally. It also happens with --sort > > srcline. The column sizing code could probably be somewhat smarter and > > always allow the last column to become as wide as needed. But that's > > something that should be done separately; I don't think it belongs > > into this patch. > > Maybe something like this? Thanks. Should do the same thing for srcfile. One potential issue is that the srclines/files can be potentially very long, so it may be needed to give them a limit if they're not the last column. -Andi