From: Pavel Machek <pavel@ucw.cz>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Michal Marek <mmarek@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
Namhyung Kim <namhyung@gmail.com>,
Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
x86@kernel.org, live-patching@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v9 20/20] x86/asm/power: Create stack frames in hibernate_asm_64.S
Date: Sun, 9 Aug 2015 21:14:18 +0200 [thread overview]
Message-ID: <20150809191418.GA26785@amd> (raw)
In-Reply-To: <851bb2a8da6225a9392a1a0b7b69745b89d21384.1438963009.git.jpoimboe@redhat.com>
On Fri 2015-08-07 11:50:29, Josh Poimboeuf wrote:
> swsusp_arch_suspend() and restore_registers() are callable non-leaf
> functions which don't honor CONFIG_FRAME_POINTER, which can result in
> bad stack traces. Also they aren't annotated as ELF callable functions
> which can confuse tooling.
>
> Create a stack frame for them when CONFIG_FRAME_POINTER is enabled and
> give them proper ELF function annotations.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
17,20: Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2015-08-09 19:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 16:50 [PATCH v9 00/20] Compile-time stack validation Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 01/20] x86/asm: Frame pointer macro cleanup Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 02/20] x86/asm: Add C versions of frame pointer macros Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 03/20] x86/stackvalidate: Compile-time stack validation Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 04/20] x86/stackvalidate: Add file and directory ignores Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 05/20] x86/stackvalidate: Add ignore macros Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 06/20] x86/xen: Add stack frame dependency to hypercall inline asm calls Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 07/20] x86/paravirt: Add stack frame dependency to PVOP " Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 08/20] x86/paravirt: Create a stack frame in PV_CALLEE_SAVE_REGS_THUNK Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 09/20] x86/amd: Set ELF function type for vide() Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 10/20] x86/reboot: Add ljmp instructions to stackvalidate whitelist Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 11/20] x86/xen: Add xen_cpuid() and xen_setup_gdt() to stackvalidate whitelists Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 12/20] x86/asm/crypto: Create stack frames in aesni-intel_asm.S Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 13/20] x86/asm/crypto: Move .Lbswap_mask data to .rodata section Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 14/20] x86/asm/crypto: Move jump_table " Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 15/20] x86/asm/crypto: Create stack frames in clmul_ghash_mul/update() Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 16/20] x86/asm/entry: Create stack frames in thunk functions Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 17/20] x86/asm/acpi: Create a stack frame in do_suspend_lowlevel() Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 18/20] x86/asm: Create stack frames in rwsem functions Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 19/20] x86/asm/efi: Create a stack frame in efi_call() Josh Poimboeuf
2015-08-07 16:50 ` [PATCH v9 20/20] x86/asm/power: Create stack frames in hibernate_asm_64.S Josh Poimboeuf
2015-08-09 19:14 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150809191418.GA26785@amd \
--to=pavel@ucw.cz \
--cc=andi@firstfloor.org \
--cc=bernd@petrovitsch.priv.at \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=namhyung@gmail.com \
--cc=palves@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox