From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754614AbbHIW7g (ORCPT ); Sun, 9 Aug 2015 18:59:36 -0400 Received: from down.free-electrons.com ([37.187.137.238]:48417 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751248AbbHIW7c (ORCPT ); Sun, 9 Aug 2015 18:59:32 -0400 Date: Mon, 10 Aug 2015 00:59:30 +0200 From: Alexandre Belloni To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [PATCH 21/27] rtc: Export OF module alias information in missing drivers Message-ID: <20150809225930.GE3411@piout.net> References: <1438273132-20926-1-git-send-email-javier@osg.samsung.com> <1438273132-20926-22-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438273132-20926-22-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/07/2015 at 18:18:46 +0200, Javier Martinez Canillas wrote : > The I2C core always reports the MODALIAS uevent as "i2c: regardless if the driver was matched using the I2C id_table or the > of_match_table. So technically there's no need for a driver to export > the OF table since currently it's not used. > > In fact, the I2C device ID table is mandatory for I2C drivers since > a i2c_device_id is passed to the driver's probe function even if the > I2C core used the OF table to match the driver. > > And since the I2C core uses different tables, OF-only drivers needs to > have duplicated data that has to be kept in sync and also the dev node > compatible manufacturer prefix is stripped when reporting the MODALIAS. > > To avoid the above, the I2C core behavior may be changed in the future > to not require an I2C device table for OF-only drivers and report the > OF module alias. So, it's better to also export the OF table to prevent > breaking module autoloading if that happens. > > Signed-off-by: Javier Martinez Canillas Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com