From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753121AbbHJD1a (ORCPT ); Sun, 9 Aug 2015 23:27:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53617 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752661AbbHJD13 (ORCPT ); Sun, 9 Aug 2015 23:27:29 -0400 Date: Sun, 9 Aug 2015 20:27:28 -0700 From: Greg Kroah-Hartman To: Vladimir Zapolskiy Cc: Philipp Zabel , Heiko =?iso-8859-1?Q?St=FCbner?= , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: sram: extend usage of reserved partitions Message-ID: <20150810032728.GA29840@kroah.com> References: <1439156402-10207-1-git-send-email-vladimir_zapolskiy@mentor.com> <1439156402-10207-2-git-send-email-vladimir_zapolskiy@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439156402-10207-2-git-send-email-vladimir_zapolskiy@mentor.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 10, 2015 at 12:40:02AM +0300, Vladimir Zapolskiy wrote: > This change adds functionality to operate on reserved SRAM partitions > described in device tree file. Two partition properties are added, > "pool" and "export", the first one allows to share a specific partition > for usage by a kernel consumer in the same manner as it is done for > the whole SRAM device, and "export" property provides access to some > SRAM area from userspace over sysfs interface. Practically it is > possible to specify both properties for an SRAM partition, however > simultaneous access from a kernel consumer and from userspace is not > serialized, but still the combination may be useful for debugging > purpose. > > Signed-off-by: Vladimir Zapolskiy > --- > To test SRAM partition export to userspace it might be sufficient > to add an exported subnode, write data to created binary attribute file, > do soft reboot and read the contents of the same binary attribute > file. Aware of any potential use of SRAM by a bootloader etc. > > To give an idea how to use "pool" partition feature here is an example > for Freescale iMX6Q SabreAuto with CODA driver as a user: > > arch/arm/boot/dts/imx6q.dtsi @@ -82,6 +82,10 @@ > compatible = "mmio-sram"; > reg = <0x00900000 0x40000>; > clocks = <&clks IMX6QDL_CLK_OCRAM>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x00900000 0x40000>; > }; > > aips-bus@02000000 { /* AIPS1 */ > arch/arm/boot/dts/imx6qdl-sabreauto.dtsi @@ -490,3 +490,18 @@ > 0x0000c000 0x1404a38e 0x00000000>; > }; > }; > + > +&ocram { > + #address-cells = <1>; > + #size-cells = <1>; > + > + vpu_iram: vpu_iram { > + reg = <0x00008000 0x00021000>; > + pool; > + }; > +}; > + > +&vpu { > + iram = <&vpu_iram>; > +}; > Putting a diff in a patch changelog is tricky, do you really need it? And why send 2 copies of this patch, what changed? confused, greg k-h