public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Mike Rapoport <mike.rapoport@gmail.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
	Brian Swetland <swetland@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] mm: export shmem_zero_setup for modules
Date: Mon, 10 Aug 2015 00:47:09 -0700	[thread overview]
Message-ID: <20150810074709.GA5696@infradead.org> (raw)
In-Reply-To: <1439187861-3864-6-git-send-email-mike.rapoport@gmail.com>

On Mon, Aug 10, 2015 at 09:24:20AM +0300, Mike Rapoport wrote:
> to allow building Android ASHMEM as module

NAK.  This is not functionality that should be used by a module to
start, and even if it was exporting functionality is only acceptable
for proper mainline modules, not code in the staging tree.

  reply	other threads:[~2015-08-10  7:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10  6:24 [PATCH 0/6] staging: android: allow building some drivers as a module Mike Rapoport
2015-08-10  6:24 ` [PATCH 1/6] staging: android: allow building timed_gpio " Mike Rapoport
2015-08-10  6:24 ` [PATCH 2/6] staging: android: sync_debug.c: add include for linux/module.h Mike Rapoport
2015-08-10  6:24 ` [PATCH 3/6] staging: android: combine sync.o and sync_debug.o into sync-core.o Mike Rapoport
2015-08-10  6:24 ` [PATCH 4/6] staging: android: allow building sync and sw_sync as a module Mike Rapoport
2015-08-10  6:24 ` [PATCH 5/6] mm: export shmem_zero_setup for modules Mike Rapoport
2015-08-10  7:47   ` Christoph Hellwig [this message]
2015-08-10  6:24 ` [PATCH 6/6] staging: android: allow building ashmem as a module Mike Rapoport
2015-08-10 15:38 ` [PATCH 0/6] staging: android: allow building some drivers " Greg Kroah-Hartman
2015-08-10 20:10   ` Mike Rapoport
2015-08-10 21:03     ` Greg Kroah-Hartman
2015-08-11 13:09       ` Mike Rapoport
2015-08-11 18:10         ` Greg Kroah-Hartman
2015-08-11 19:08           ` [PATCH] staging: android: TODO: remove irrelevant parts Mike Rapoport
2015-08-11 23:39             ` Joe Perches
2015-08-12 18:08               ` [PATCH v2] staging: android: update TODO Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150810074709.GA5696@infradead.org \
    --to=hch@infradead.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.rapoport@gmail.com \
    --cc=swetland@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox