From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754274AbbHJIFv (ORCPT ); Mon, 10 Aug 2015 04:05:51 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:36188 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753812AbbHJIFs (ORCPT ); Mon, 10 Aug 2015 04:05:48 -0400 Date: Mon, 10 Aug 2015 17:06:24 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Andrew Morton , gioh.kim@lge.com, Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC zsmalloc 1/4] zsmalloc: keep max_object in size_class Message-ID: <20150810080624.GA600@swordfish> References: <1439190743-13933-1-git-send-email-minchan@kernel.org> <1439190743-13933-2-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439190743-13933-2-git-send-email-minchan@kernel.org> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (08/10/15 16:12), Minchan Kim wrote: > Every zspage in a size_class has same max_objects so we could > move it to a size_class. > > Signed-off-by: Minchan Kim > --- > mm/zsmalloc.c | 22 ++++++++++------------ > 1 file changed, 10 insertions(+), 12 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index f135b1b..491491a 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -33,8 +33,6 @@ > * page->freelist: points to the first free object in zspage. > * Free objects are linked together using in-place > * metadata. > - * page->objects: maximum number of objects we can store in this > - * zspage (class->zspage_order * PAGE_SIZE / class->size) > * page->lru: links together first pages of various zspages. > * Basically forming list of zspages in a fullness group. > * page->mapping: class index and fullness group of the zspage > @@ -206,6 +204,7 @@ struct size_class { > * of ZS_ALIGN. > */ > int size; > + int max_objects; may be change it to objs_per_zspage or something similar? we have class->pages_per_zspage, so class->objs_per_zspage sounds ok. otherwise, it's class->max_objects, which gives a false feeling that there is class's limit on objects, not zspages's. -ss