public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com,
	luto@kernel.org, torvalds@linux-foundation.org,
	kan.liang@intel.com, mingo@kernel.org,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf/x86: Add an MSR PMU driver
Date: Mon, 10 Aug 2015 13:42:56 +0200	[thread overview]
Message-ID: <20150810114256.GZ16853@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150810111936.GC31841@krava.brq.redhat.com>

On Mon, Aug 10, 2015 at 01:19:36PM +0200, Jiri Olsa wrote:
> On Tue, Aug 04, 2015 at 02:01:20AM -0700, tip-bot for Andy Lutomirski wrote:
> 
> SNIP
> 
> > +	/* unsupported modes and filters */
> > +	if (event->attr.exclude_user   ||
> > +	    event->attr.exclude_kernel ||
> > +	    event->attr.exclude_hv     ||
> > +	    event->attr.exclude_idle   ||
> > +	    event->attr.exclude_host   ||
> > +	    event->attr.exclude_guest  ||
> > +	    event->attr.sample_period) /* no sampling */
> > +		return -EINVAL;
> > +
> > +	event->hw.idx = -1;
> > +	event->hw.event_base = msr[cfg].msr;
> > +	event->hw.config = cfg;
> > +
> > +	return 0;
> > +}
> > +
> > +static inline u64 msr_read_counter(struct perf_event *event)
> > +{
> > +	u64 now;
> > +
> > +	if (event->hw.event_base)
> > +		rdmsrl(event->hw.event_base, now);
> > +	else
> > +		now = rdtsc();
> 
> not sure itf there's newer version, but I needed attached change
> to make it compile on latest Arnaldo's tree

You need tip/x86/asm merged in.

      reply	other threads:[~2015-08-10 11:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 15:49 [PATCH RFC V2 1/1] x86, perf: Add a freq pmu driver Kan Liang
2015-07-21  3:10 ` Stephane Eranian
2015-07-21  6:01   ` Andy Lutomirski
2015-07-21  6:21     ` Stephane Eranian
2015-07-21  6:23       ` Andy Lutomirski
2015-07-21  9:55         ` Peter Zijlstra
2015-07-21  9:55 ` Peter Zijlstra
2015-07-23 15:44   ` Stephane Eranian
2015-07-23 15:52     ` Andy Lutomirski
2015-07-23 16:00       ` Stephane Eranian
2015-07-23 17:25     ` Andi Kleen
2015-07-26 16:31 ` Jiri Olsa
2015-07-27 17:40   ` Andy Lutomirski
2015-08-04  9:01 ` [tip:perf/core] perf/x86: Add an MSR PMU driver tip-bot for Andy Lutomirski
2015-08-04 14:50   ` Andy Lutomirski
2015-08-04 15:03     ` Liang, Kan
2015-08-04 18:00       ` Andy Lutomirski
2015-08-04 18:11         ` Liang, Kan
2015-08-04 18:13           ` Andy Lutomirski
2015-08-04 20:39             ` Liang, Kan
2015-08-06 15:21               ` Peter Zijlstra
2015-08-06 15:30                 ` Andy Lutomirski
2015-08-06 15:59                   ` Peter Zijlstra
2015-08-07  8:34                     ` Peter Zijlstra
2015-08-10  2:12                       ` Andy Lutomirski
2015-08-10 14:02                       ` Liang, Kan
2015-08-10 14:24                         ` Peter Zijlstra
2015-08-06 17:44                 ` Liang, Kan
2015-08-10 11:19   ` Jiri Olsa
2015-08-10 11:42     ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150810114256.GZ16853@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox