From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbbHJMsa (ORCPT ); Mon, 10 Aug 2015 08:48:30 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:36802 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbbHJMs3 (ORCPT ); Mon, 10 Aug 2015 08:48:29 -0400 Date: Mon, 10 Aug 2015 13:48:24 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/27] mfd: stw481x: Export I2C module alias information Message-ID: <20150810124824.GE3249@x1> References: <1438273132-20926-1-git-send-email-javier@osg.samsung.com> <1438273132-20926-2-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1438273132-20926-2-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Jul 2015, Javier Martinez Canillas wrote: > The I2C core always reports the MODALIAS uevent as "i2c: regardless if the driver was matched using the I2C id_table or the > of_match_table. So the driver needs to export the I2C table and this > be built into the module or udev won't have the necessary information > to auto load the correct module when the device is added. > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/mfd/stw481x.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/mfd/stw481x.c b/drivers/mfd/stw481x.c > index 7ceb3df09e25..ca613df36143 100644 > --- a/drivers/mfd/stw481x.c > +++ b/drivers/mfd/stw481x.c > @@ -231,6 +231,7 @@ static const struct i2c_device_id stw481x_id[] = { > { "stw481x", 0 }, > { }, > }; > +MODULE_DEVICE_TABLE(i2c, stw481x_id); > > static const struct of_device_id stw481x_match[] = { > { .compatible = "st,stw4810", }, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog