From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932204AbbHJPij (ORCPT ); Mon, 10 Aug 2015 11:38:39 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47907 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450AbbHJPih (ORCPT ); Mon, 10 Aug 2015 11:38:37 -0400 X-Sasl-enc: t8NX+zlSGSVzxA4nXSlTIDxdbC+SCITMPz3QZa3LnD/Z 1439221116 Date: Mon, 10 Aug 2015 08:38:35 -0700 From: Greg Kroah-Hartman To: Mike Rapoport Cc: Brian Swetland , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] staging: android: allow building some drivers as a module Message-ID: <20150810153835.GC13461@kroah.com> References: <1439187861-3864-1-git-send-email-mike.rapoport@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439187861-3864-1-git-send-email-mike.rapoport@gmail.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 10, 2015 at 09:24:15AM +0300, Mike Rapoport wrote: > Hi, > > These patches enable building of timed_gpio, sync* and ashmem as a module Why do you want to do this? Does it ever make sense to do this type of thing for your kernel? What does changing these to modules enable you to do differently? As it is, I think the code should stay non-modular. thanks, greg k-h