From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932447AbbHJRnW (ORCPT ); Mon, 10 Aug 2015 13:43:22 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:36344 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932097AbbHJRnU (ORCPT ); Mon, 10 Aug 2015 13:43:20 -0400 Date: Mon, 10 Aug 2015 10:43:16 -0700 From: Glenn Griffin To: David Miller Cc: pshelar@nicira.com, netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments Message-ID: <20150810174316.GA19574@google.com> References: <20150803165654.GA16892@google.com> <20150803.140328.574050334230752525.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150803.140328.574050334230752525.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 03, 2015 at 02:03:28PM -0700, David Miller wrote: > From: Glenn Griffin > Date: Mon, 3 Aug 2015 09:56:54 -0700 > > > openvswitch modifies the L4 checksum of a packet when modifying > > the ip address. When an IP packet is fragmented only the first > > fragment contains an L4 header and checksum. Prior to this change > > openvswitch would modify all fragments, modifying application data > > in non-first fragments, causing checksum failures in the > > reassembled packet. > > > > Signed-off-by: Glenn Griffin > > --- > > Changes in v2: > > - Compare frag_off in network byte order rather than host byte order > > Applied and queued up for -stable. I noticed this change didn't seem to make it into 4.2-rc6. I'm not too familiar with the release schedule so wasn't sure if that was expected or an oversight. Will this remain queued up until the 4.3 merge window opens?