Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling with '<' and '>' key

Jiri Olsa
2015-08-09T11:21:44Z

On Sun, Aug 09, 2015 at 07:35:42PM +0900, Namhyung Kim wrote:
> Hi Jiri,
>
> On Sun, Aug 09, 2015 at 11:30:24AM +0200, Jiri Olsa wrote:
> > On Sun, Aug 09, 2015 at 05:21:01PM +0900, Namhyung Kim wrote:
> > > Currently perf TUI report browser doesn't support horizontal scrolling.
> > > So if terminal width is smaller than the actual contents, there's no way
> > > to see them. This patch adds support horizontal movement by '<' and '>'
> > > keys.
> >
> > nice, I wonder we could also have some way to scroll
> > by the column width.. it might be more eye friendly?
> > would need to try first ;-)
>
> Good suggesion. Please see below..
>
> >
> > I also tried it with SKIP_COLS_STEP=1, and it wasn't bad
>
> OK.
>
> >
> > how about having several scroll step options? like:
> > , . - SKIP_COLS_STEP=1
> > < > - SKIP_COLS_STEP=10
> > CTRL-< > - SKIP_COLS_STEP=columns width
>
> I tried to use CTRL but it seems not working.
>
>
> >
> > we could also bind some of this to regular arrows
> > with SHIFT or CTRL, bacause it's probably the most
> > convenient binding for this
>
> Yes, I agree with you. But I don't know how to bind the arrow keys
> with SHIFT or CTRL to do the thing. So I just changed that < > to
> make SKIP_COLS_STEP = column width.
>
>
> Thanks,
> Namhyung
>
>
>
> From 8e1f0a8be36895f9f37df133dcc8020e123b76e9 Mon Sep 17 00:00:00 2001
> From: Namhyung Kim <namhyung@kernel.org>
> Date: Sun, 9 Aug 2015 19:25:32 +0900
> Subject: [PATCH] perf hists browser: Move to prev/next column start by '<' or
> '>' keys
>
> Jiri said that it'd be more eye-friendly if it can move by column
> widths. So change the keys to do it rather than jumping 10 characters.
> Also add ',' and '.' keys which reside same position in the keyboard to
> move by 1 characters.

I like it ;-)

Tested-by: Jiri Olsa <jolsa@redhat.com>

anyway let's hear some other opinions

thanks,
jirka