From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933678AbbHKCQ4 (ORCPT ); Mon, 10 Aug 2015 22:16:56 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:36318 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933572AbbHKCQy (ORCPT ); Mon, 10 Aug 2015 22:16:54 -0400 Date: Tue, 11 Aug 2015 11:00:34 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Ingo Molnar , Peter Zijlstra , LKML , David Ahern , Andi Kleen Subject: Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling with '<' and '>' key Message-ID: <20150811020034.GA2488@sejong> References: <1439108462-16391-1-git-send-email-namhyung@kernel.org> <20150809093024.GA17069@krava.brq.redhat.com> <20150809103542.GA3415@danjae.kornet> <20150809112139.GD17069@krava.brq.redhat.com> <20150810155004.GB2521@kernel.org> <20150810224603.GC27431@krava.redhat.com> <20150810225822.GH2521@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150810225822.GH2521@kernel.org> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On Mon, Aug 10, 2015 at 07:58:22PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Aug 11, 2015 at 12:46:03AM +0200, Jiri Olsa escreveu: > > On Mon, Aug 10, 2015 at 12:50:04PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Sun, Aug 09, 2015 at 01:21:39PM +0200, Jiri Olsa escreveu: > > > > On Sun, Aug 09, 2015 at 07:35:42PM +0900, Namhyung Kim wrote: > > > > > Jiri said that it'd be more eye-friendly if it can move by column > > > > > widths. So change the keys to do it rather than jumping 10 characters. > > > > > Also add ',' and '.' keys which reside same position in the keyboard to > > > > > move by 1 characters. > > > > > > > > I like it ;-) > > > > > > Humm, I don't, its not natural, I doubt anyone will think about using , > > > and . to move by one character right/left, ditto for <>, I think we > > > should just recover <- and -> (left and right arrows) for navigation, > > > leave ENTER to be what -> was doing and esc for what <- does, in fact it > > > is already like that. > > > > I would ;-) anyway I also think arrows are the best, but I thought we > > dont want to break existing interface much > > In this case I think we can, enter and esc are really well know keys for > entering and escaping from a place, and we have them working forever > doing that, its just that at some time I used <- as an alias for ESC and > -> as alias for ENTER. > > I.e. for people using ESC and ENTER, this will not be noticed :-) Yes, but I guess many people use arrow keys more than ESC and ENTER since we use up/down arrow keys anyway. I do want to use left/right arrow for scrolling, but I'm afraid that it'll bother existing users.. Thanks, Namhyung > > > > Probably using shift or control or alt + <- -> for moving one column at > > > at time is enough, but humm, is there value in that? > > > > it'd really help for perf mem output, which is quite wide.. and we probably > > have more wide outputs, or users with narrow terminals ;-) > > I'm not going against horizontal scrolling, it is needed, sure thing, > its surprising we are doing this only now. What I am asking is this fine > scrolling of one column per <- or -> keypress, but I really need to try > it with things like 'perf mem', I thought that when you pressed '>', in > this patch, it would move entire sort key columns, not just one vertical > column one character wide, right? > > - Arnaldo