Re: [PATCH v4 06/10] libnvdimm, pmem: push call to ioremap_cache out of line

Dan Williams
2015-08-11T16:21:00Z

On Tue, Aug 11, 2015 at 5:51 AM, Christoph Hellwig <hch@lst.de> wrote:
> On Mon, Aug 10, 2015 at 11:38:23PM -0400, Dan Williams wrote:
>> In preparation for deprecating ioremap_cache() push its usage into arch
>> code where it deleted in a later globabl conversion of ioremap_cache()
>> to arch_memremap().
>
> I don't really see the point of this patch. Two patches later
> we'll get rid arch_memremap_pmem anyway.
>
> I'd rather fold this and the next two patches into a single one,
> and keep the new arch_memremap_pmem_flags as a inline in io.h.

Yeah, it made more sense at its position in the old series, but now
that ioremap_cache() will be around for one last development cycle we
can squash this.