From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965119AbbHKOBk (ORCPT <rfc822;w@1wt.eu>);
	Tue, 11 Aug 2015 10:01:40 -0400
Received: from mail-la0-f54.google.com ([209.85.215.54]:33389 "EHLO
	mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964936AbbHKOBj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 11 Aug 2015 10:01:39 -0400
Date: Tue, 11 Aug 2015 16:00:30 +0200
From: Olof Johansson <olof@lixom.net>
To: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: arm@kernel.org, linux-kernel@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>, Roman Yeryomin <roman@advem.lv>,
        linus.walleij@linaro.org
Subject: Re: ARM:Gemini:clocksource update for 4.3
Message-ID: <20150811140030.GS30181@localhost>
References: <1438955763-17260-1-git-send-email-ulli.kroll@googlemail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1438955763-17260-1-git-send-email-ulli.kroll@googlemail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Fri, Aug 07, 2015 at 03:56:00PM +0200, Hans Ulli Kroll wrote:
> Hi all,
> 
> sorry for being late in this cycle ...
> I asked Roman to send me his patchset with 2 patched, but he don't respond.
> 
> So here is my patchset.
> But I used one more patch to cleanup the register definitions in the driver.
> These where somewhat annoying, if a "autocomplete" editor is used.
> 
> The other patches changes to the timer1 and add timer3 as free running.
> The initial driver missed also to enable the interrupt in the device, which 
> is also added.

First of all, what are these patches based against? At least the first
one doesn't apply to our tree, possibly due to conflicts with Linus
Walleij's patch "ARM: gemini: convert to GENERIC_CLOCKEVENTS" from 2013.

A couple of general comments about the patch series:

1) Please feel free to include a git shortlog with the cover letter

2) We try to standardize on "ARM: <platform>: <patch description"
   as subject, i.e. here it would be "ARM: gemini: ...". (Space and
   capitalization is the difference). I'll fix this up when applying, just
   mentioning it for future patches.

3) While it's nice to see some updates and cleanups to the clock driver in the
   mach directory, what would be even more awesome would be an effort to move
   it into the drivers/clocksource directory where other platforms now have
   their drivers. If you want to continue working on these, please consider
   doing that work!


-Olof