From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965234AbbHKOPu (ORCPT ); Tue, 11 Aug 2015 10:15:50 -0400 Received: from down.free-electrons.com ([37.187.137.238]:34423 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965124AbbHKOPt (ORCPT ); Tue, 11 Aug 2015 10:15:49 -0400 Date: Tue, 11 Aug 2015 16:15:47 +0200 From: Alexandre Belloni To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Adrian Huang , Egbert Eich , Diego Ercolani , Borislav Petkov , Alessandro Zummo , rtc-linux@googlegroups.com Subject: Re: [PATCH] drivers/rtc: fix compile warning introduced by 1s reboot fix Message-ID: <20150811141547.GP3411@piout.net> References: <1439301844-22710-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439301844-22710-1-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On 11/08/2015 at 10:04:04 -0400, Paul Gortmaker wrote : > We currently see this warning: > > drivers/rtc/rtc-cmos.c:851:7: warning: unused variable 'err' > > introduced by commit 7b4a008088a28ea936fffbbfa770d0184468a0ce ("rtc-cmos: > Cancel alarm timer if alarm time is equal to now+1 seconds"). > > Presumably some WIP version of the commit was doing error checking > but then the variable was not removed prior to submission, and the > pending commits weren't on kernel.org for kbuild bot to spot the new > warning created. > > Cc: Adrian Huang > Cc: Egbert Eich > Cc: Diego Ercolani > Cc: Borislav Petkov > Cc: Alexandre Belloni > Cc: Alessandro Zummo > Cc: rtc-linux@googlegroups.com > Signed-off-by: Paul Gortmaker > --- > > [Note: patch is against linux-next, so if the rtc tree is rebased, > then the above commit ID reference will be stale. Feel free to > adjust the commit log appropriately, if need be, or even squash > this into the original offending patch, if rebasing back that far. > Also ensuring your tree is on kernel.org will allow kbuild bot > to spot these on your behalf via the zero day builds.] > I'm pretty sure my rtc-next branch on kernel.org already carry the fix. I fixed it on monday: 2015-08-10 07:12:44 (GMT). It just seems that linux-next has not been updated since then. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com