Re: [PATCH] thermal: remove power allocator from list of default governors

Srinivas Pandruvada
2015-08-05T16:21:12Z

On Wed, 2015-08-05 at 09:37 +0100, Javi Merino wrote:
> On Tue, Aug 04, 2015 at 05:39:21PM +0100, Dmitry Torokhov wrote:
> > As it currently stands the power allocator governor can not handle
> > thermal zones that are not specifically crafted and therefore can not be
> > used as a default governor.
> >
> > Users need to explicitly enable this governor for thermal zones that do
> > have enough information for its operation.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> > drivers/thermal/Kconfig | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index 0390044..34d05d3 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -82,14 +82,6 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
> > Select this if you want to let the user space manage the
> > platform thermals.
> >
> > -config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
> > - bool "power_allocator"
> > - select THERMAL_GOV_POWER_ALLOCATOR
> > - help
> > - Select this if you want to control temperature based on
> > - system and device power allocation. This governor can only
> > - operate on cooling devices that implement the power API.
> > -
>
> Currently the only way we have for a thermal zone configured from
> device tree to use a governor from the kernel boot is by using
> THERMAL_DEFAULT_GOV_*. If we remove this option some devices won't
> have a workable thermal framework until userspace is up and running.
>
> Would you rather have the power allocator governor accept every
> thermal zone?
May be allow to select when the binded cooling device can support this
governor.

Thanks,
Srinivas

> Cheers,
> Javi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html