public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kuleshov <kuleshovmail@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Ungerer <gerg@uclinux.org>,
	linux-m68k <linux-m68k@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] m68k/coldfire: use PFN_DOWN macro
Date: Wed, 12 Aug 2015 00:09:54 +0600	[thread overview]
Message-ID: <20150811180954.GA12610@localhost> (raw)
In-Reply-To: <CAMuHMdV5bS1W5NkQnezYq_V9x2b1y2yQzgco1VNGzx9y9umapA@mail.gmail.com>

On 08-11-15, Geert Uytterhoeven wrote:
> Hi Alexander,
> 
> On Tue, Aug 11, 2015 at 6:57 PM, Alexander Kuleshov
> <kuleshovmail@gmail.com> wrote:
> > Replace ((x) >> PAGE_SHIFT) with the predefined PFN_DOWN macro.
> >
> > Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> > ---
> >  arch/m68k/coldfire/m54xx.c | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/m68k/coldfire/m54xx.c b/arch/m68k/coldfire/m54xx.c
> > index 075aaab..f7836c6 100644
> > --- a/arch/m68k/coldfire/m54xx.c
> > +++ b/arch/m68k/coldfire/m54xx.c
> > @@ -25,4 +25,5 @@
> >  #include <asm/m54xxgpt.h>
> >  #ifdef CONFIG_MMU
> >  #include <asm/mmu_context.h>
> > +#include <linux/pfn.h>
> >  #endif
> >
> >  /***************************************************************************/
> > @@ -91,1 +92,1 @@ static void __init mcf54xx_bootmem_alloc(void)
> 
> The numbers in the above line don't make sense?
> 

Hello Geert, Are you about `-91,1 +92,1....`? Or what numbers. If you are about
this, sorry for noise. I've checked the patch with the git apply --check and it
will return some errors.

If other things are normal I will resend correct patch.

Thank you.

  reply	other threads:[~2015-08-11 18:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 16:57 [PATCH] m68k/coldfire: use PFN_DOWN macro Alexander Kuleshov
2015-08-11 17:45 ` Geert Uytterhoeven
2015-08-11 18:09   ` Alexander Kuleshov [this message]
2015-08-11 19:02     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150811180954.GA12610@localhost \
    --to=kuleshovmail@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox