From: Greg Kroah-Hartman <greg@kroah.com>
To: Mike Rapoport <mike.rapoport@gmail.com>
Cc: Brian Swetland <swetland@google.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/6] staging: android: allow building some drivers as a module
Date: Tue, 11 Aug 2015 11:10:17 -0700 [thread overview]
Message-ID: <20150811181017.GA29765@kroah.com> (raw)
In-Reply-To: <CABpLfogi+pqcT0GTuYNCqZvKABC_Qk2hzJGAUXcEhn08uJajbg@mail.gmail.com>
On Tue, Aug 11, 2015 at 04:09:28PM +0300, Mike Rapoport wrote:
> On Tue, Aug 11, 2015 at 12:03 AM, Greg Kroah-Hartman <greg@kroah.com> wrote:
> > On Mon, Aug 10, 2015 at 11:10:37PM +0300, Mike Rapoport wrote:
> >> On Mon, Aug 10, 2015 at 6:38 PM, Greg Kroah-Hartman <greg@kroah.com> wrote:
> >> > On Mon, Aug 10, 2015 at 09:24:15AM +0300, Mike Rapoport wrote:
> >> >> Hi,
> >> >>
> >> >> These patches enable building of timed_gpio, sync* and ashmem as a module
> >> >
> >> > Why do you want to do this?
> >>
> >> Apparently I've misread "- make sure things build as modules properly"
> >> line in drivers/staging/android/TODO...
> >> My bad.
> >
> > Nope, not your fault, I forgot about that. We should remove that TODO
> > item, as it doesn't make sense for these "non-discoverable" modules to
> > be built as a module.
> >
> > Care to make a patch for that?
>
> I'll make, no problem.
> What about other irrelevant parts of that TODO, like, e.g., dead
> Brian Sweetland address? Remove them as well?
Yes, please remove that as well, good catch.
greg k-h
next prev parent reply other threads:[~2015-08-11 18:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 6:24 [PATCH 0/6] staging: android: allow building some drivers as a module Mike Rapoport
2015-08-10 6:24 ` [PATCH 1/6] staging: android: allow building timed_gpio " Mike Rapoport
2015-08-10 6:24 ` [PATCH 2/6] staging: android: sync_debug.c: add include for linux/module.h Mike Rapoport
2015-08-10 6:24 ` [PATCH 3/6] staging: android: combine sync.o and sync_debug.o into sync-core.o Mike Rapoport
2015-08-10 6:24 ` [PATCH 4/6] staging: android: allow building sync and sw_sync as a module Mike Rapoport
2015-08-10 6:24 ` [PATCH 5/6] mm: export shmem_zero_setup for modules Mike Rapoport
2015-08-10 7:47 ` Christoph Hellwig
2015-08-10 6:24 ` [PATCH 6/6] staging: android: allow building ashmem as a module Mike Rapoport
2015-08-10 15:38 ` [PATCH 0/6] staging: android: allow building some drivers " Greg Kroah-Hartman
2015-08-10 20:10 ` Mike Rapoport
2015-08-10 21:03 ` Greg Kroah-Hartman
2015-08-11 13:09 ` Mike Rapoport
2015-08-11 18:10 ` Greg Kroah-Hartman [this message]
2015-08-11 19:08 ` [PATCH] staging: android: TODO: remove irrelevant parts Mike Rapoport
2015-08-11 23:39 ` Joe Perches
2015-08-12 18:08 ` [PATCH v2] staging: android: update TODO Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811181017.GA29765@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.rapoport@gmail.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox