Re: [PATCH 0/6] staging: android: allow building some drivers as a module

Mike Rapoport
2015-08-11T13:09:31Z

On Tue, Aug 11, 2015 at 12:03 AM, Greg Kroah-Hartman <greg@kroah.com> wrote:
> On Mon, Aug 10, 2015 at 11:10:37PM +0300, Mike Rapoport wrote:
>> On Mon, Aug 10, 2015 at 6:38 PM, Greg Kroah-Hartman <greg@kroah.com> wrote:
>> > On Mon, Aug 10, 2015 at 09:24:15AM +0300, Mike Rapoport wrote:
>> >> Hi,
>> >>
>> >> These patches enable building of timed_gpio, sync* and ashmem as a module
>> >
>> > Why do you want to do this?
>>
>> Apparently I've misread "- make sure things build as modules properly"
>> line in drivers/staging/android/TODO...
>> My bad.
>
> Nope, not your fault, I forgot about that. We should remove that TODO
> item, as it doesn't make sense for these "non-discoverable" modules to
> be built as a module.
>
> Care to make a patch for that?

I'll make, no problem.
What about other irrelevant parts of that TODO, like, e.g., dead
Brian Sweetland address? Remove them as well?
> thanks,
>
> greg k-h

--
Sincerely yours,
Mike.