From: Christoph Hellwig <hch@infradead.org>
To: katsuki.uwatoko@toshiba.co.jp
Cc: linux-arm-kernel@lists.infradead.org, david@fromorbit.com,
gangchen@rdamicro.com, linux@arm.linux.org.uk,
karanvir.singh@hgst.com, luca@skylable.com,
christopher.squires@hgst.com, edwin@skylable.com,
wayne.burri@hgst.com, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: enabling libgcc for 64-bit divisions, was Re: PROBLEM: XFS on ARM corruption 'Structure needs cleaning'
Date: Tue, 11 Aug 2015 23:24:45 -0700 [thread overview]
Message-ID: <20150812062445.GA4520@infradead.org> (raw)
In-Reply-To: <C6D0D499B56584katsuki.uwatoko@toshiba.co.jp>
On Wed, Aug 12, 2015 at 12:56:25AM +0000, katsuki.uwatoko@toshiba.co.jp wrote:
> On Sat, 13 Jun 2015 08:52:09 +1000, Dave Chinner wrote:
>
> > Yup, that's looking like a toolchain bug. Thread about arm directory
> > read corruption:
>
> I think that this is not a toolchain bug, this is related to
> Subject: [PATCH v2 1/1] ARM : missing corrupted reg in __do_div_asm
> http://www.spinics.net/lists/arm-kernel/msg426684.html
Maybe it's time to rely on gcc to handle 64 bit divisions now?
I've been pretty annoyed at the amount of 32-bit architecture build
failures due to the lack of support for native 64-bit divisions, and
the ugly do_div hackery to work around it.
We're living in a world where we are using a lot of 64-bit CPUs and
people optimize for them, so it might be a good time to start relying
on the compiler to get these right on older CPUs.
How bad is gcc's code for 64-bit divisions on arm and x86 these days?
Is there still a good case for offloading work the compiler should be
doing on the programmer?
next parent reply other threads:[~2015-08-12 6:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5579B804.9050707@skylable.com>
[not found] ` <20150612122108.GB60661@bfoster.bfoster>
[not found] ` <557AD4D4.3010901@skylable.com>
[not found] ` <20150612225209.GA20262@dastard>
[not found] ` <C6D0D499B56584katsuki.uwatoko@toshiba.co.jp>
2015-08-12 6:24 ` Christoph Hellwig [this message]
2015-08-12 15:49 ` enabling libgcc for 64-bit divisions, was Re: PROBLEM: XFS on ARM corruption 'Structure needs cleaning' Linus Torvalds
2015-08-12 22:20 ` Andy Lutomirski
2015-08-12 22:36 ` Linus Torvalds
2015-08-12 22:39 ` Andy Lutomirski
2015-08-13 3:28 ` Andrew Morton
2015-10-08 15:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150812062445.GA4520@infradead.org \
--to=hch@infradead.org \
--cc=christopher.squires@hgst.com \
--cc=david@fromorbit.com \
--cc=edwin@skylable.com \
--cc=gangchen@rdamicro.com \
--cc=karanvir.singh@hgst.com \
--cc=katsuki.uwatoko@toshiba.co.jp \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=luca@skylable.com \
--cc=torvalds@linux-foundation.org \
--cc=wayne.burri@hgst.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox