From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964933AbbHLKSx (ORCPT <rfc822;w@1wt.eu>);
	Wed, 12 Aug 2015 06:18:53 -0400
Received: from mail-pd0-f178.google.com ([209.85.192.178]:33022 "EHLO
	mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964905AbbHLKSt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 12 Aug 2015 06:18:49 -0400
Date: Wed, 12 Aug 2015 15:48:45 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: ralf@linux-mips.org
Cc: linaro-kernel@lists.linaro.org, Thomas Gleixner <tglx@linutronix.de>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Hongliang Tao <taohl@lemote.com>, Huacai Chen <chenhc@lemote.com>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:MIPS" <linux-mips@linux-mips.org>,
        Michael Opdenacker <michael.opdenacker@free-electrons.com>,
        Valentin Rothberg <valentinrothberg@gmail.com>
Subject: Re: [PATCH] MIPS:loongson64:hpet: Drop the dangling 'set_mode'
 assignment
Message-ID: <20150812101845.GA20238@linux>
References: <45d35e38970b9c7196faa3a6892d2b5e4e6f40aa.1438851213.git.viresh.kumar@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <45d35e38970b9c7196faa3a6892d2b5e4e6f40aa.1438851213.git.viresh.kumar@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06-08-15, 14:25, Viresh Kumar wrote:
> This should have been removed by: 604cbe1de254 ("MIPS: loongson64/timer:
> Migrate to new 'set-state' interface") commit, but it wasn't.
> 
> Remove it now.
> 
> Fixes: 604cbe1de254 ("MIPS: loongson64/timer: Migrate to new 'set-state' interface")
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Ralf:
> 
> Not sure how it was left out in my series, but I thought it should have
> been caught by the compilers as the function hpet_set_mode doesn't exist
> today.
> 
> Either merge it with the offending commit or keep it separate.
> 
>  arch/mips/loongson64/loongson-3/hpet.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/loongson64/loongson-3/hpet.c b/arch/mips/loongson64/loongson-3/hpet.c
> index 950096e8d7cd..bf9f1a77f0e5 100644
> --- a/arch/mips/loongson64/loongson-3/hpet.c
> +++ b/arch/mips/loongson64/loongson-3/hpet.c
> @@ -228,7 +228,6 @@ void __init setup_hpet_timer(void)
>  	cd->name = "hpet";
>  	cd->rating = 320;
>  	cd->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT;
> -	cd->set_mode = hpet_set_mode;
>  	cd->set_state_shutdown = hpet_set_state_shutdown;
>  	cd->set_state_periodic = hpet_set_state_periodic;
>  	cd->set_state_oneshot = hpet_set_state_oneshot;

Ping

-- 
viresh