From: Afzal Mohammed <afzal.mohd.ma@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2] sched,fair: Remove > u32 weight handling for delta
Date: Wed, 12 Aug 2015 16:42:27 +0530 [thread overview]
Message-ID: <20150812111226.GA3192@afzalpc> (raw)
In-Reply-To: <1436206755-2540-1-git-send-email-afzal.mohd.ma@gmail.com>
Hi Peter,
On Mon, Jul 06, 2015 at 11:49:15PM +0530, Afzal Mohammed wrote:
> scaled down weight 'fact' would not be > u32 rather than unlikely as the
> weight being passed in __calc_delta() is either 'se->load.weight' or
> NICE_O_LOAD. 'se->load.weight' would be one of the values of
> prio_to_weight[] in the case of task, while in the case of task group it
> would be capped to MAX_SHARES. All those possible values can fit in u32.
> Hence remove the initial > u32 handling on 'fact'.
>
> Signed-off-by: Afzal Mohammed <afzal.mohd.ma@gmail.com>
> ---
>
> v2: expand change log on why weight can fit in u32, remove incorrect
> comments.
>
> kernel/sched/fair.c | 7 -------
> 1 file changed, 7 deletions(-)
bool __weak patch_adds_some_value(void)
{
return (~3 asm instruction less for calc_delta) && (less LOC);
}
if (patch_adds_some_value() && revised_message_okay())
please help $subject reach mainline;
Regards
Afzal
prev parent reply other threads:[~2015-08-12 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 2:44 [PATCH] sched,fair: Remove > u32 weight handling for delta Afzal Mohammed
2015-07-06 11:44 ` Peter Zijlstra
2015-07-06 13:34 ` Afzal Mohammed
2015-07-06 14:39 ` Afzal Mohammed
2015-07-06 18:19 ` [PATCH v2] " Afzal Mohammed
2015-08-12 11:12 ` Afzal Mohammed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150812111226.GA3192@afzalpc \
--to=afzal.mohd.ma@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox