From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754703AbbHLLMd (ORCPT ); Wed, 12 Aug 2015 07:12:33 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35239 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967AbbHLLMc (ORCPT ); Wed, 12 Aug 2015 07:12:32 -0400 Date: Wed, 12 Aug 2015 16:42:27 +0530 From: Afzal Mohammed To: linux-kernel@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH v2] sched,fair: Remove > u32 weight handling for delta Message-ID: <20150812111226.GA3192@afzalpc> References: <20150706133407.GA5861@afzalpc> <1436206755-2540-1-git-send-email-afzal.mohd.ma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436206755-2540-1-git-send-email-afzal.mohd.ma@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On Mon, Jul 06, 2015 at 11:49:15PM +0530, Afzal Mohammed wrote: > scaled down weight 'fact' would not be > u32 rather than unlikely as the > weight being passed in __calc_delta() is either 'se->load.weight' or > NICE_O_LOAD. 'se->load.weight' would be one of the values of > prio_to_weight[] in the case of task, while in the case of task group it > would be capped to MAX_SHARES. All those possible values can fit in u32. > Hence remove the initial > u32 handling on 'fact'. > > Signed-off-by: Afzal Mohammed > --- > > v2: expand change log on why weight can fit in u32, remove incorrect > comments. > > kernel/sched/fair.c | 7 ------- > 1 file changed, 7 deletions(-) bool __weak patch_adds_some_value(void) { return (~3 asm instruction less for calc_delta) && (less LOC); } if (patch_adds_some_value() && revised_message_okay()) please help $subject reach mainline; Regards Afzal