* [PATCH] Staging: media/bcm2048: Fix line over 80 characters warning as detected by checkpatch.pl
@ 2015-08-12 11:12 Shah, Yash (Y.)
2015-08-12 11:19 ` Pali Rohár
0 siblings, 1 reply; 3+ messages in thread
From: Shah, Yash (Y.) @ 2015-08-12 11:12 UTC (permalink / raw)
To: mchehab@osg.samsung.com, gregkh@linuxfoundation.org,
hans.verkuil@cisco.com, pali.rohar@gmail.com,
prabhakar.csengg@gmail.com, hamohammed.sa@gmail.com,
luis@debethencourt.com, wsa@the-dreams.de,
elfring@users.sourceforge.net, carlos@cgarcia.org,
vthakkar1994@gmail.com
Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Babu, Viswanathan (V.)
From: Yash Shah <yshah1@visteon.com>
Fix line over 80 characters warning as detected by checkpatch.pl
Signed-off-by: Yash Shah <yshah1@visteon.com>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 8bc68e2..d36350e 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2243,7 +2243,8 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf,
tmpbuf[i] = bdev->rds_info.radio_text[bdev->rd_index+i+2];
tmpbuf[i+1] = bdev->rds_info.radio_text[bdev->rd_index+i+1];
- tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i] & 0xf0) >> 4;
+ tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i]
+ & 0xf0) >> 4;
if ((bdev->rds_info.radio_text[bdev->rd_index+i] &
BCM2048_RDS_CRC_MASK) == BCM2048_RDS_CRC_UNRECOVARABLE)
tmpbuf[i+2] |= 0x80;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: media/bcm2048: Fix line over 80 characters warning as detected by checkpatch.pl
2015-08-12 11:12 [PATCH] Staging: media/bcm2048: Fix line over 80 characters warning as detected by checkpatch.pl Shah, Yash (Y.)
@ 2015-08-12 11:19 ` Pali Rohár
2015-08-12 13:33 ` Frans Klaver
0 siblings, 1 reply; 3+ messages in thread
From: Pali Rohár @ 2015-08-12 11:19 UTC (permalink / raw)
To: Shah, Yash (Y.)
Cc: mchehab@osg.samsung.com, gregkh@linuxfoundation.org,
hans.verkuil@cisco.com, prabhakar.csengg@gmail.com,
hamohammed.sa@gmail.com, luis@debethencourt.com,
wsa@the-dreams.de, elfring@users.sourceforge.net,
carlos@cgarcia.org, vthakkar1994@gmail.com,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Babu, Viswanathan (V.)
On Wednesday 12 August 2015 11:12:49 Shah, Yash (Y.) wrote:
> From: Yash Shah <yshah1@visteon.com>
>
> Fix line over 80 characters warning as detected by checkpatch.pl
>
> Signed-off-by: Yash Shah <yshah1@visteon.com>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 8bc68e2..d36350e 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2243,7 +2243,8 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf,
>
> tmpbuf[i] = bdev->rds_info.radio_text[bdev->rd_index+i+2];
> tmpbuf[i+1] = bdev->rds_info.radio_text[bdev->rd_index+i+1];
> - tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i] & 0xf0) >> 4;
> + tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i]
> + & 0xf0) >> 4;
> if ((bdev->rds_info.radio_text[bdev->rd_index+i] &
> BCM2048_RDS_CRC_MASK) == BCM2048_RDS_CRC_UNRECOVARABLE)
> tmpbuf[i+2] |= 0x80;
Hi! I think that code after this change is less readable as before.
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: media/bcm2048: Fix line over 80 characters warning as detected by checkpatch.pl
2015-08-12 11:19 ` Pali Rohár
@ 2015-08-12 13:33 ` Frans Klaver
0 siblings, 0 replies; 3+ messages in thread
From: Frans Klaver @ 2015-08-12 13:33 UTC (permalink / raw)
To: Pali Rohár
Cc: Shah, Yash (Y.), mchehab@osg.samsung.com,
gregkh@linuxfoundation.org, hans.verkuil@cisco.com,
prabhakar.csengg@gmail.com, hamohammed.sa@gmail.com,
luis@debethencourt.com, wsa@the-dreams.de,
elfring@users.sourceforge.net, carlos@cgarcia.org,
vthakkar1994@gmail.com, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Babu, Viswanathan (V.)
On Wed, Aug 12, 2015 at 1:19 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Wednesday 12 August 2015 11:12:49 Shah, Yash (Y.) wrote:
>> From: Yash Shah <yshah1@visteon.com>
>>
>> Fix line over 80 characters warning as detected by checkpatch.pl
>>
>> Signed-off-by: Yash Shah <yshah1@visteon.com>
>> ---
>> drivers/staging/media/bcm2048/radio-bcm2048.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
>> index 8bc68e2..d36350e 100644
>> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
>> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
>> @@ -2243,7 +2243,8 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf,
>>
>> tmpbuf[i] = bdev->rds_info.radio_text[bdev->rd_index+i+2];
>> tmpbuf[i+1] = bdev->rds_info.radio_text[bdev->rd_index+i+1];
>> - tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i] & 0xf0) >> 4;
>> + tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i]
>> + & 0xf0) >> 4;
>> if ((bdev->rds_info.radio_text[bdev->rd_index+i] &
>> BCM2048_RDS_CRC_MASK) == BCM2048_RDS_CRC_UNRECOVARABLE)
>> tmpbuf[i+2] |= 0x80;
>
> Hi! I think that code after this change is less readable as before.
I agree. I would do something about 'bdev->rds_info.radio_text'
instead and shorten all three lines.
Frans
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-12 13:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-12 11:12 [PATCH] Staging: media/bcm2048: Fix line over 80 characters warning as detected by checkpatch.pl Shah, Yash (Y.)
2015-08-12 11:19 ` Pali Rohár
2015-08-12 13:33 ` Frans Klaver
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox