From: "Pali Rohár" <pali.rohar@gmail.com>
To: "Shah, Yash (Y.)" <yshah1@visteon.com>
Cc: "mchehab@osg.samsung.com" <mchehab@osg.samsung.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"hans.verkuil@cisco.com" <hans.verkuil@cisco.com>,
"prabhakar.csengg@gmail.com" <prabhakar.csengg@gmail.com>,
"hamohammed.sa@gmail.com" <hamohammed.sa@gmail.com>,
"luis@debethencourt.com" <luis@debethencourt.com>,
"wsa@the-dreams.de" <wsa@the-dreams.de>,
"elfring@users.sourceforge.net" <elfring@users.sourceforge.net>,
"carlos@cgarcia.org" <carlos@cgarcia.org>,
"vthakkar1994@gmail.com" <vthakkar1994@gmail.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Babu, Viswanathan (V.)" <vbabu3@visteon.com>
Subject: Re: [PATCH] Staging: media/bcm2048: Fix line over 80 characters warning as detected by checkpatch.pl
Date: Wed, 12 Aug 2015 13:19:36 +0200 [thread overview]
Message-ID: <20150812111935.GA15037@pali> (raw)
In-Reply-To: <20150812111245.GA24492@ubuntu>
On Wednesday 12 August 2015 11:12:49 Shah, Yash (Y.) wrote:
> From: Yash Shah <yshah1@visteon.com>
>
> Fix line over 80 characters warning as detected by checkpatch.pl
>
> Signed-off-by: Yash Shah <yshah1@visteon.com>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 8bc68e2..d36350e 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2243,7 +2243,8 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf,
>
> tmpbuf[i] = bdev->rds_info.radio_text[bdev->rd_index+i+2];
> tmpbuf[i+1] = bdev->rds_info.radio_text[bdev->rd_index+i+1];
> - tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i] & 0xf0) >> 4;
> + tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i]
> + & 0xf0) >> 4;
> if ((bdev->rds_info.radio_text[bdev->rd_index+i] &
> BCM2048_RDS_CRC_MASK) == BCM2048_RDS_CRC_UNRECOVARABLE)
> tmpbuf[i+2] |= 0x80;
Hi! I think that code after this change is less readable as before.
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2015-08-12 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 11:12 [PATCH] Staging: media/bcm2048: Fix line over 80 characters warning as detected by checkpatch.pl Shah, Yash (Y.)
2015-08-12 11:19 ` Pali Rohár [this message]
2015-08-12 13:33 ` Frans Klaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150812111935.GA15037@pali \
--to=pali.rohar@gmail.com \
--cc=carlos@cgarcia.org \
--cc=devel@driverdev.osuosl.org \
--cc=elfring@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=mchehab@osg.samsung.com \
--cc=prabhakar.csengg@gmail.com \
--cc=vbabu3@visteon.com \
--cc=vthakkar1994@gmail.com \
--cc=wsa@the-dreams.de \
--cc=yshah1@visteon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox