Re: [PATCH 07/20] regmap: Without bus read() or write(), force use_single_rw

Mark Brown
2015-08-12T11:13:34Z

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

On Wed, Aug 12, 2015 at 12:12:32PM +0200, Markus Pargmann wrote:
> The implementation of regmap bus read() and write() methods are
> optional. Therefore we have to handle busses which do not have these
> functions. If raw read() and write() is not supported we have to use
> reg_read and reg_write always.
>
> This patch sets use_single_rw if read() or write() is not set.

> - map->use_single_rw = config->use_single_rw;
> + map->use_single_rw = config->use_single_rw || !bus->read || !bus->write;

This doesn't follow, we should be able to support write only or read
only buses. There are some out there.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]