Re: [PATCH 14/20] regmap: Add raw_write/read checks for max_raw_write/read sizes

Mark Brown
2015-08-12T11:58:09Z

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

On Wed, Aug 12, 2015 at 12:12:39PM +0200, Markus Pargmann wrote:

> Check in regmap_raw_read() and regmap_raw_write() for correct maximum
> sizes of the operations. Return -E2BIG if this size is not supported
> because it is too big.

Why not just split the transaction up like your other changes did?

> Also this patch causes an uninitialized variable warning so it
> initializes ret (although not necessary).

That's just shutting the warning up without understanding where it came
from or why this is a good way of handling it :(

> @@ -2273,8 +2276,14 @@ int regmap_raw_read(struct regmap *map, unsigned int reg, void *val,
>
> map->lock(map->lock_arg);
>
> - if (regmap_volatile_range(map, reg, val_count) || map->cache_bypass ||
> - map->cache_type == REGCACHE_NONE) {
> + if (map->bus->read &&

This change doesn't match your commit log...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]