From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754652AbbHLNbe (ORCPT ); Wed, 12 Aug 2015 09:31:34 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:36595 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752017AbbHLNbc (ORCPT ); Wed, 12 Aug 2015 09:31:32 -0400 Date: Wed, 12 Aug 2015 22:30:31 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Minchan Kim , linux-kernel@vger.kernel.org, Sergey Senozhatsky , Sergey Senozhatsky Subject: Re: [PATCH 4.2] zram: fix pool names truncation Message-ID: <20150812133031.GA569@swordfish> References: <1439299983-8070-1-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439299983-8070-1-git-send-email-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (08/11/15 22:33), Sergey Senozhatsky wrote: > found this reading the code just now. I do believe we need this > patch in 4.2 (before 4.3), because the bug breaks new devices > creation under some specific conditions -- new pool names are > getting truncated to only 3 digits and, thus, > debugfs_create_dir() fails. > > The commit message contains more details. > Hello, I have an alternative fix; a somewhat better one. We actually don't have to snprintf() there anything. We already have zram->disk->disk_name constructed exactly same way, so we can pass it to zram_meta_alloc() instead of device_id. I'll send out a patch shortly. -ss > > Andrew, can you please pick up this patch? > > > Sergey Senozhatsky (1): > zram: fix max pool limitation > > drivers/block/zram/zram_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > -- > 2.5.0 >