From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751996AbbHLVJD (ORCPT ); Wed, 12 Aug 2015 17:09:03 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:24415 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826AbbHLVJA (ORCPT ); Wed, 12 Aug 2015 17:09:00 -0400 Date: Thu, 13 Aug 2015 00:08:43 +0300 From: Dan Carpenter To: Tim Waugh , Sudip Mukherjee Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman Subject: [patch] paride: fix a return in pd_detect() Message-ID: <20150812210843.GC8068@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In this function returning non-zero means the hardware was detected and zero means it wasn't. This is a failure path so we should return zero. Fixes: 9f4ba6b05869 ('paride: use new parport device model') Signed-off-by: Dan Carpenter diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c index b9242d7..4e75c5f 100644 --- a/drivers/block/paride/pd.c +++ b/drivers/block/paride/pd.c @@ -877,7 +877,7 @@ static int pd_detect(void) par_drv = pi_register_driver(name); if (!par_drv) { pr_err("failed to register %s driver\n", name); - return -1; + return 0; } if (pd_drive_count == 0) { /* nothing spec'd - so autoprobe for 1 */