From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292AbbHMMKt (ORCPT ); Thu, 13 Aug 2015 08:10:49 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:33971 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559AbbHMMKs (ORCPT ); Thu, 13 Aug 2015 08:10:48 -0400 Date: Thu, 13 Aug 2015 17:40:34 +0530 From: Sudip Mukherjee To: Dan Carpenter Cc: Tim Waugh , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [patch] paride: fix a return in pd_detect() Message-ID: <20150813121034.GA4938@sudip-pc> References: <20150812210843.GC8068@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150812210843.GC8068@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 13, 2015 at 12:08:43AM +0300, Dan Carpenter wrote: > In this function returning non-zero means the hardware was detected and > zero means it wasn't. This is a failure path so we should return zero. > > Fixes: 9f4ba6b05869 ('paride: use new parport device model') > Signed-off-by: Dan Carpenter Acked-by: Sudip Mukherjee regards sudip