From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752646AbbHMNAK (ORCPT ); Thu, 13 Aug 2015 09:00:10 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37834 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbbHMNAI (ORCPT ); Thu, 13 Aug 2015 09:00:08 -0400 Date: Thu, 13 Aug 2015 14:59:12 +0200 From: Thierry Reding To: Heiko Schocher Cc: linux-kernel@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2] drm/panel: add lg4573 driver Message-ID: <20150813125911.GA2561@ulmo> References: <1433829082-29197-1-git-send-email-hs@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline In-Reply-To: <1433829082-29197-1-git-send-email-hs@denx.de> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 09, 2015 at 07:51:22AM +0200, Heiko Schocher wrote: > Add support for LG LG4573 480x800 4,3" panel. the LG4573 > is used on the LG LCD LB043WV2-SD01, an industrial 4.3" TFT > panel with SPI control interface. >=20 > Signed-off-by: Heiko Schocher >=20 > --- >=20 > Changes in v2: > - add comments from Thierry Reding: > - fix some spelling issues > - remove "power-on-delay" > - remove display timings usage from DT, instead specify the > timing in the driver. > - change config symbol to DRM_PANEL_LG_LG4573 > - change filename to panel-lg-lg4573.c > - get rid of power_on_delay > - use cpu_to_be16() > - rework lg4573_spi_write_u16_array() > - introduce lg4573_spi_write_dcs() > - reworked error reporting >=20 > .../devicetree/bindings/panel/lg,lg4573.txt | 19 + > drivers/gpu/drm/panel/Kconfig | 8 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-lg-lg4573.c | 382 +++++++++++++++= ++++++ > 4 files changed, 410 insertions(+) > create mode 100644 Documentation/devicetree/bindings/panel/lg,lg4573.txt > create mode 100644 drivers/gpu/drm/panel/panel-lg-lg4573.c There were a couple of review comments that you missed, but I've addressed them while applying. Might be good to give it[0] a spin just to make sure I didn't accidentally break anything. Thierry [0]: git://anongit.freedesktop.org/tegra/linux#drm/panel/for-next --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVzJScAAoJEN0jrNd/PrOhhvcP/RrSOzsUSUCG2a+Xspxgl5F+ 22yuVN9Amk0K4KvqdxQIen42qDoOoRBrGo33coeGZSvZIO2MZNTb6VdeTZZ1/nFv NvZhIWzn1AlVzQ9ybmp0rS+Q+eN9QzDjW4NWs/mjcAfcnJg0SmYrNwWoboUk0cQo jScyNIWpqkDdSh1QJ+ZN6YnAuhNbuNR+ayJv0hWQ/gEO2yqZlP6QfvsmDSWXzIvG 8hfz7u3JYy5zxu//54ds/mooMpmJrPjMI9c1L8sfqKooFDT+zpiAaPdyDWSDE1EQ Ol1R3Z82j9kfnpG4ZVjr6nBvv4Q4drto80ScfRmW7zVPg67m0lEFSbeb6VAiRdGz cpPVmdUaTewJ2oywzEaH8BdXmDCQVbdxv0wR242i03BNmSMrDxcnLZD8exJLojja AMbeNf6/ew8yvVsYB2jNAohYPAIUj29X/ct2WpJEdB//2vw3BYUDPv1oO8zSiPDg uPjLqzitSXe+cCClWrdf3/uFpl8v+UiRpirYOw0VBiQWDHh4XqxI6kaifVDI3yaT 0IBFTXyJcwEg+gP9YSNWFwxg4iaXSUODRAh2fkOIW/oB+NY7Islu3MUBIIhmJ2rM FjowTR4w1fKWmww09HFtDSgixjZ/WpnK90YfUBEZyT1g/gIPMH2uxNY4MSfk5hWl 5xpo10QwYhCkE2H6Ls7X =vh9F -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X--